build: enable client SDK unit tests in CI #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/client-unit-tests
branch
from
1b75adb to
d63fa65
Compare
cwaldren-ld
commented
Oct 24, 2024
| description: 'The target test framework to use.' | ||
| required: false | ||
| default: 'net6.0' | ||
| test_verbosity: |
Contributor
Author
There was a problem hiding this comment.
Without this, it just appears like the tests are hanging in CI. I can see the value of not having this when running locally, but it's nice to have the record when waiting remotely.
cwaldren-ld
commented
Oct 24, 2024
| run: | | ||
| dotnet restore ${{ inputs.test_project_file }} | ||
| dotnet test --framework=net6.0 ${{ inputs.test_project_file }} | ||
| dotnet test -v=${{ inputs.test_verbosity }} --framework=${{ inputs.target_test_framework }} ${{ inputs.test_project_file }} |
Contributor
Author
There was a problem hiding this comment.
Previously, it was passing net6 as the framework. I believe this was causing it to silently just not run tests at all. The target for the client tests is net7.
tanderson-ld
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.