Skip to content

fix: Change trackDuration argument from float to double#306

Open
mattrmc1 wants to merge 1 commit into
mmccarthy/AIC-2727/extend-metrics-ai-metricsfrom
mmccarthy/fix/float-to-double
Open

fix: Change trackDuration argument from float to double#306
mattrmc1 wants to merge 1 commit into
mmccarthy/AIC-2727/extend-metrics-ai-metricsfrom
mmccarthy/fix/float-to-double

Conversation

@mattrmc1

@mattrmc1 mattrmc1 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Public interface signature change on ILdAiConfigTracker is a binary-breaking change for external implementers, though call sites passing float literals still compile via implicit widening.

Overview
ILdAiConfigTracker.TrackDuration and LdAiConfigTracker.TrackDuration now take double durationMs instead of float, matching how durations are already stored internally and how Stopwatch.Elapsed.TotalMilliseconds / AiMetrics.DurationMs are produced.

Internal call sites in TrackDurationOf and TrackMetricsOf no longer cast millisecond values to float before recording. Unit tests were updated to pass double literals where they exercise TrackDuration directly.

Reviewed by Cursor Bugbot for commit f6cb49d. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant