fix: Change trackDuration argument from float to double#306
Open
mattrmc1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Public interface signature change on ILdAiConfigTracker is a binary-breaking change for external implementers, though call sites passing float literals still compile via implicit widening.
Overview
ILdAiConfigTracker.TrackDurationandLdAiConfigTracker.TrackDurationnow takedouble durationMsinstead offloat, matching how durations are already stored internally and howStopwatch.Elapsed.TotalMilliseconds/AiMetrics.DurationMsare produced.Internal call sites in
TrackDurationOfandTrackMetricsOfno longer cast millisecond values tofloatbefore recording. Unit tests were updated to passdoubleliterals where they exerciseTrackDurationdirectly.Reviewed by Cursor Bugbot for commit f6cb49d. Bugbot is set up for automated code reviews on this repo. Configure here.