fix: catch exceptions thrown by template interpolation #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sdk-890-invalid-templates
branch
from
4e32ae0 to
2864ac2
Compare
kinyoklion
reviewed
Nov 15, 2024
cwaldren-ld
force-pushed
the
cw/sdk-890-invalid-templates
branch
from
de94c03 to
6d0f425
Compare
kinyoklion
approved these changes
Nov 18, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Nov 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.1](LaunchDarkly.ServerSdk.Ai-v0.1.0...LaunchDarkly.ServerSdk.Ai-v0.1.1) (2024-11-18) ### Bug Fixes * catch exceptions thrown by template interpolation ([#43](#43)) ([7a6cfd5](7a6cfd5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at catching exceptions generated by the interpolation process. It wraps each call to interpolate with a try/catch and individually reports an error via the logger.
I know that the exception message in this particular case (in unit test) is pretty useless, but it also seems bad to simply swallow the error with no extra context.