ci: add permissions to caller jobs and upgrade release-please-action to v5#119
Merged
kinyoklion merged 2 commits intoMay 19, 2026
Merged
Conversation
…to v5 The release-please workflow fails with startup_failure because caller jobs invoking ci.yml and publish.yml do not declare explicit permissions. Also upgrades release-please-action from v4 to v5. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default mode and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1daf2ab. Configure here.
When a permissions block is specified, unmentioned permissions default to none. The ci.yml reusable workflow needs contents: read for actions/checkout. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
tanderson-ld
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Release Please
startup_failureby adding explicitpermissionsto theciandpublishcaller jobs. Also upgrades release-please-action from v4 to v5.Review & Testing Checklist for Human
cicaller job'scontents: readis sufficient foractions/checkoutNotes
Same fix pattern as dotnet-core PR #241. Caller jobs need explicit permissions because the reusable workflows declare permissions that exceed the restricted org defaults. Added
contents: readto thecicaller per Bugbot feedback — whenpermissionsis declared, unmentioned permissions default tonone.Link to Devin session: https://app.devin.ai/sessions/54e32482848742c19ebf9c374efdc833
Requested by: @kinyoklion