Skip to content

chore: scope v4 branch workflows to v4 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-zeisler merged 2 commits into from
May 27, 2026
Merged

chore: scope v4 branch workflows to v4 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
057ac3a
[SDK-2119] chore: scope v4 branch workflows to v4 (cross-maintain Go …
aaron-zeisler May 26, 2026
4fa5407
[SDK-2119] chore: hardcode release-please target-branch to v4
aaron-zeisler May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-go-versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
branch: ["v3"]
branch: ["v3", "v4"]
fail-fast: false
env:
officialLatestVersion: ${{ needs.check-go-eol.outputs.latest }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Build and Test SDK
on:
push:
branches: [ 'v3', 'feat/**' ]
branches: [ 'v4', 'feat/**' ]
Copy link
Copy Markdown

@cursor cursor Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI branch filter replaces v3 instead of adding v4

High Severity

The push and pull_request branch filters in ci.yml replace v3 with v4 instead of adding v4 alongside v3. This removes all CI coverage (tests, lint, contract tests) for v3 pushes and PRs. The PR description explicitly states the intent is to "add v4 to the branch lists," and check-go-versions.yml correctly uses ["v3", "v4"], confirming this is unintentional.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 057ac3a. Configure here.

Copy link
Copy Markdown
Author

@aaron-zeisler aaron-zeisler May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a per-branch workflow file. It lives on the v4 branch, and on push events GitHub Actions reads the workflow file from the branch being pushed to.

The check-go-versions.yml matrix ["v3", "v4"] is deliberately different: it's a schedule workflow, and schedule events read the workflow file from the default branch only.

paths-ignore:
- '**.md' # Don't run CI on markdown changes.
pull_request:
branches: [ 'v3', 'feat/**' ]
branches: [ 'v4', 'feat/**' ]
paths-ignore:
- '**.md'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Run Release Please
on:
push:
branches:
- v3
- v4
Copy link
Copy Markdown
Member

@keelerm84 keelerm84 May 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target branch for the release please action is v3. I believe the latest version of this GHA allows you to omit that branch entirely, and it will infer it from the branch that triggered the run.

Refer to target branch on their docs.

Copy link
Copy Markdown

@cursor cursor Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release-please drops v3 branch from push trigger

High Severity

The push trigger in release-please.yml replaces v3 with v4 instead of including both. This prevents release-please from running on v3 pushes, so future v3 releases won't get automated release PRs. The PR description says "add v4 to the push trigger," and the dynamic target-branch: ${{ github.ref_name }} was designed to handle both branches — but only if both are listed.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 057ac3a. Configure here.

Copy link
Copy Markdown
Author

@aaron-zeisler aaron-zeisler May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: This is a per-branch workflow file.

workflow_dispatch:

jobs:
Expand All @@ -15,4 +15,4 @@ jobs:
steps:
- uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4.4.0
with:
target-branch: v3
target-branch: v4
Loading