Skip to content

chore: Revert .release-please-manifest.json#42

Merged
aaron-zeisler merged 1 commit into
v4from
aaronz/revert-release-please-manifest
May 28, 2026
Merged

chore: Revert .release-please-manifest.json#42
aaron-zeisler merged 1 commit into
v4from
aaronz/revert-release-please-manifest

Conversation

@aaron-zeisler
Copy link
Copy Markdown

@aaron-zeisler aaron-zeisler commented May 27, 2026

Revert the change I previously made to the release-please manifest. This file's updates are automated by release-please.

After this pull request is merged to the v4 branch, I'll kick off the release-please Github Action, which should correctly update this file to v4.0.0 (instead of v5.0.0, as was done in this pull request).

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.


Note

Cursor Bugbot is generating a summary for commit 329c416. Configure here.

Revert the change I previously made to the release-please manifest. This file's updates are automated by release-please.
@aaron-zeisler aaron-zeisler requested a review from a team as a code owner May 27, 2026 22:27
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 329c416. Configure here.

@@ -1,3 +1,3 @@
{
".": "4.0.0"
".": "3.1.1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifest version inconsistent with v4 module path

High Severity

The manifest is being reverted to version 3.1.1, but go.mod already declares the module as github.com/launchdarkly/go-jsonstream/v4, and all internal imports, plus README.md, reference /v4. This mismatch means release-please will think the current version is 3.1.1 and may attempt to produce v3.x releases for a codebase whose module path requires v4.x tags, resulting in broken or missing releases.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 329c416. Configure here.

@aaron-zeisler aaron-zeisler merged commit 1f43c02 into v4 May 28, 2026
14 checks passed
@aaron-zeisler aaron-zeisler deleted the aaronz/revert-release-please-manifest branch May 28, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants