Skip to content

Update ios-client-sdk SPM requirement to 11.x series#47

Merged
kinyoklion merged 5 commits intomainfrom
devin/1772498706-update-macos-sdk
Mar 3, 2026
Merged

Update ios-client-sdk SPM requirement to 11.x series#47
kinyoklion merged 5 commits intomainfrom
devin/1772498706-update-macos-sdk

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 3, 2026

Summary

Updates the Swift Package Manager version requirement for ios-client-sdk:

  • Changes kind from upToNextMinorVersion to upToNextMajorVersion
  • Changes minimumVersion from 9.6.0 to 11.0.0

The previous constraint locked SPM resolution to 9.6.x only. This PR moves to the 11.x series, so SPM will resolve to any version in [11.0.0, 12.0.0). The latest release is 11.1.1.

The 11.0.0 breaking change is about dispatching public completions to the main thread for Swift 6 compatibility. The APIs used in this example (LDClient, LDContextBuilder, LDConfig, boolVariation, observe) appear unchanged.

Updates since last revision

  • Fixed indentation in pbxproj requirement block to match surrounding formatting (commit 024050c).
  • Updated minimumVersion from 9.6.0 to 11.0.0 per reviewer feedback to move to the 11.x series (commit c150285).
  • Updated MACOSX_DEPLOYMENT_TARGET from 10.13 to 12.0 in both Debug and Release configurations — SDK 11.x requires macOS 12.0 minimum, which was the root cause of the CI run failure.
  • Updated Package.resolved to pin ios-client-sdk 11.1.1 (rev 8b56cf8) and swift-eventsource 3.3.0 (rev 5705170), matching SDK 11.1.1's declared dependency.

Review & Testing Checklist for Human

  • Review breaking changes across 10.0.0 and 11.0.0. Only the 11.0.0 changelog was checked during this PR. The 10.0.0 release may contain additional breaking changes that could affect the example code. Review the full changelog between 9.6.x and 11.x.
  • Verify Package.resolved is accepted by Xcode. The file was updated manually (no Xcode available) — the originHash field was removed and SHAs were resolved from GitHub tags. Confirm Xcode opens the project without re-resolving or erroring on the lock file.
  • Confirm the deployment target bump to macOS 12.0 is acceptable. This drops support for macOS 10.13–11.x, which is required by SDK 11.x but worth confirming as intentional.

Suggested test plan: Open the project in Xcode, confirm SPM resolves without issues, build and run with a valid mobile key, and verify the SDK initializes, evaluates the flag, and the observe callback fires.

Notes

  • CI build check passes. The run check was previously failing due to the deployment target mismatch and should now pass with the 12.0 fix.
  • Not tested locally (no Xcode environment available).
  • Requested by: rlamb@launchdarkly.com
  • Devin Session

Changes the ios-client-sdk SPM requirement from upToNextMinorVersion
(limited to 9.6.x) to upToNextMajorVersion (allows 9.6.0 to <10.0.0),
enabling resolution to the latest 9.x release.

Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
@kinyoklion kinyoklion marked this pull request as ready for review March 3, 2026 21:16
@kinyoklion kinyoklion requested a review from a team as a code owner March 3, 2026 21:16
@kinyoklion
Copy link
Member

The latest version of this SDK is 11, so we should move to the 11.x series.

Moves from 9.x series to 11.x series per reviewer feedback.
The 11.0.0 breaking change is Swift 6 threading compatibility
(completions dispatched to main thread), which does not affect
the APIs used in this example.

Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
@devin-ai-integration devin-ai-integration bot changed the title Update SPM version requirement to upToNextMajorVersion for ios-client-sdk Update ios-client-sdk SPM requirement to 11.x series Mar 3, 2026
@kinyoklion
Copy link
Member

Devin, review your human checklist. I think some items are now addressed by CI.

For the resolution of SPM can you not run xcode to update the resolved version?

@kinyoklion
Copy link
Member

Checked the failed CI

- Update MACOSX_DEPLOYMENT_TARGET from 10.13 to 12.0 (SDK 11.x requires macOS 12.0)
- Update Package.resolved to pin ios-client-sdk 11.1.1 and swift-eventsource 3.3.0

Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
@devin-ai-integration
Copy link
Contributor Author

Addressed both items:

  1. Updated the human checklist — CI now covers build and run, so the checklist focuses on reviewing breaking changes across 10.0.0/11.0.0 rather than duplicating what CI validates.

  2. Updated Package.resolved — pinned to ios-client-sdk 11.1.1 and swift-eventsource 3.3.0 (matching SDK 11.1.1's dependency). I don't have Xcode on this machine so I resolved the versions manually from the GitHub tag SHAs and the SDK's Package.swift.

  3. Fixed the CI run failure — the root cause was MACOSX_DEPLOYMENT_TARGET = 10.13 but SDK 11.x requires macOS 12.0. Updated both Debug and Release configurations to 12.0.

@kinyoklion kinyoklion merged commit 14cde46 into main Mar 3, 2026
4 checks passed
@kinyoklion kinyoklion deleted the devin/1772498706-update-macos-sdk branch March 3, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants