prepare 4.2.1 release

README.md

@@ -5,6 +5,11 @@ LaunchDarkly SDK for Java
 [![Javadocs](http://javadoc.io/badge/com.launchdarkly/launchdarkly-client.svg)](http://javadoc.io/doc/com.launchdarkly/launchdarkly-client)
 [![FOSSA Status](https://app.fossa.io/api/projects/git%2Bhttps%3A%2F%2Fgithub.com%2Flaunchdarkly%2Fjava-client.svg?type=shield)](https://app.fossa.io/projects/git%2Bhttps%3A%2F%2Fgithub.com%2Flaunchdarkly%2Fjava-client?ref=badge_shield)
 
+Supported Java versions
+-----------------------
+
+This version of the LaunchDarkly SDK works with Java 7 and above.
+
 Quick setup
 -----------
 

src/main/java/com/launchdarkly/client/RedisFeatureStore.java

@@ -259,6 +259,7 @@ private <T extends VersionedData> void updateItemWithVersioning(VersionedDataKin
         if (cache != null) {
           cache.invalidate(new CacheKey(kind, newItem.getKey()));
         }
+        return;
       } finally {
         if (jedis != null) {
           jedis.unwatch();

src/main/java/com/launchdarkly/client/Util.java

@@ -41,6 +41,7 @@ static Request.Builder getRequestBuilder(String sdkKey) {
   static boolean isHttpErrorRecoverable(int statusCode) {
     if (statusCode >= 400 && statusCode < 500) {
       switch (statusCode) {
+      case 400: // bad request
       case 408: // request timeout
       case 429: // too many requests
         return true;

src/test/java/com/launchdarkly/client/DefaultEventProcessorTest.java

@@ -391,6 +391,11 @@ public void sdkKeyIsSent() throws Exception {
     assertThat(req.getHeader("Authorization"), equalTo(SDK_KEY));
   }
 
+  @Test
+  public void http400ErrorIsRecoverable() throws Exception {
+    testRecoverableHttpError(400);
+  }
+
   @Test
   public void http401ErrorIsUnrecoverable() throws Exception {
     testUnrecoverableHttpError(401);

src/test/java/com/launchdarkly/client/PollingProcessorTest.java

@@ -53,6 +53,11 @@ public void testConnectionProblem() throws Exception {
     pollingProcessor.close();
     verifyAll();
   }
+
+  @Test
+  public void http400ErrorIsRecoverable() throws Exception {
+    testRecoverableHttpError(400);
+  }
 
   @Test
   public void http401ErrorIsUnrecoverable() throws Exception {

src/test/java/com/launchdarkly/client/StreamProcessorTest.java

@@ -282,6 +282,11 @@ public void streamWillReconnectAfterGeneralIOException() throws Exception {
     ConnectionErrorHandler.Action action = errorHandler.onConnectionError(new IOException());
     assertEquals(ConnectionErrorHandler.Action.PROCEED, action);
   }
+
+  @Test
+  public void http400ErrorIsRecoverable() throws Exception {
+    testRecoverableHttpError(400);
+  }
 
   @Test
   public void http401ErrorIsUnrecoverable() throws Exception {