This repository was archived by the owner on May 30, 2024. It is now read-only.
Add event sampling. Name threads. #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param samplingInterval the sampling interval. | ||
| * @return the builder | ||
| */ | ||
| public Builder samplingInterval(int samplingInterval) { |
Contributor
Author
There was a problem hiding this comment.
I copied the semantics in the go client, but putting myself in the user's shoes I prefer using a percentage value here (and everywhere else) in the form of a floating point value from 0 to 1.0 where at 1.0 all events get sent and at 0.0 none get sent. I think consistency is more important, so we should leave it or change it everywhere.
Contributor
Author
|
Corrected target branch from #43 |
|
|
||
| repositories { | ||
| mavenCentral() | ||
| mavenLocal() |
Contributor
Author
There was a problem hiding this comment.
order matters here, so we look first locally, then elsewhere.
Contributor
|
👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add event sampling. Name threads.