This repository was archived by the owner on May 30, 2024. It is now read-only.
RedisFeatureStore config and functionality additions #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param port the port for the Redis connection | ||
| * @param prefix a namespace prefix for all keys stored in Redis | ||
| * @param cacheTimeSecs an optional timeout for the in-memory cache. If set to 0, no in-memory caching will be performed | ||
| * @deprecated as of X. Please use the {@link com.launchdarkly.client.RedisFeatureStore#RedisFeatureStore(RedisFeatureStoreConfig)} constructor for a more |
Author
There was a problem hiding this comment.
Not sure what to set X to if we do decide deprecating is the way to go with these constructors
ghost
force-pushed
the
ivorp/redis-lazy-refresh
branch
from
e291b1e to
dbca075
Compare
Contributor
|
Thanks for the contribution @ivorp2 ! |
| * @param port the port for the Redis connection | ||
| * @param prefix a namespace prefix for all keys stored in Redis | ||
| * @param cacheTimeSecs an optional timeout for the in-memory cache. If set to 0, no in-memory caching will be performed | ||
| * @deprecated as of X. Please use the {@link com.launchdarkly.client.RedisFeatureStore#RedisFeatureStore(RedisFeatureStoreBuilder)} constructor for a more |
Contributor
There was a problem hiding this comment.
This will be a v1.1 release, so X should read 1.1.
Contributor
|
@ivorp2 one minor change to the Javadocs, and this looks ready to merge. Thanks for the thorough documentation! |
- Configuration options to set the Jedis pool connection and socket timeouts in the RedisFeatureStore. - Support for 3 modes of RedisFeatureStore local cache behaviour; default evict, refresh and async refresh. - A RedisFeatureStoreBuilder with it's own builder. Deprecated the old constructors for the RedisFeatureStore. - Tests for the RedisFeatureStoreBuilder.
ghost
force-pushed
the
ivorp/redis-lazy-refresh
branch
from
ee6b348 to
29cf485
Compare
Author
|
@jkodumal ah of course! Just updated the deprecation doco and rebased all the extra PR commits. Hopefully it should be good to go now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
RedisFeatureStore.RedisFeatureStorelocal cache behaviour; default evict, refresh and async refresh (see javadoc for more details on functionality).RedisFeatureStoreConfigwith it's own builder. Deprecated the old constructors for theRedisFeatureStore(I was a little daring here - deprecation isn't necessary of course).RedisFeatureStoreBuilder.Summary of the change:
We found that having the ability to set the conn and socket timeouts in the Jedis pool was useful to provide a lower hard limit on blocking refreshes. Given the default cache behaviour is a blocking expireAfterWrite (http://google.github.io/guava/releases/snapshot/api/docs/src-html/com/google/common/cache/CacheBuilder.html#line.623) - it's useful to be able to set these parameters to something lower than the default 2 seconds.
Additionally the new modes of cache operation are situationally quite useful. Specifically utilising the asynchronous refresh "mode" which decouples network I/O from stale values fully, returning the previously cached value (
FeatureRep<>) in the meantime. This should theoretically provide a optimal local cache performance, at the cost of "greater" eventual consistency.These additions were all backed by the introduction of a
RedisFeatureStoreBuildermuch like the LDClient one. This simplifies the constructor the of theRedisFeatureStoreand improving it's flexibility and ease of construction.