Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented May 16, 2016

We have interest in using the InMemoryFeatureStore for testing and local development purposes, however the public API of the store (for writing values) depends on the default scope (package private) FeatureRep<E> class.

Looking at history the previous reason was to "Give reps default scope so they don't pollute javadoc" (see: 765db3d).

Is this still a strong enough reason to make them default scoped? Is there something better we could do other than making reps public?

This change also makes Variation<> public for similar reasons.

Edit: Okay a bunch of other stuff fell forward with this change - I also made Variations, TargetRules and their associated Builders public.

Quite a bit ended up changing here - if wish to keep these package private I will perhaps look at other options to solve our use cases (like for example; adding a FeatureStore which takes a map of key values instead).

@jkodumal
Copy link
Contributor

I think we need to look at other options, unfortunately. We will want to reserve the ability to change the internal representations of feature flags without having to do major client releases. Let me know if you want to have a conversation about other ways to solve your use cases.

@jkodumal jkodumal closed this May 17, 2016
@ghost
Copy link
Author

ghost commented May 17, 2016

No worries. I will submit another potential solution in the form of a new FeatureStore which will keep reps private.

@ghost ghost mentioned this pull request May 17, 2016
eli-darkly added a commit that referenced this pull request Feb 21, 2018
cleanup doc comments and remove deprecated members
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants