This repository was archived by the owner on May 30, 2024. It is now read-only.
Making FeatureRep and Variation public #50
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have interest in using the
InMemoryFeatureStorefor testing and local development purposes, however the public API of the store (for writing values) depends on the default scope (package private)FeatureRep<E>class.Looking at history the previous reason was to "Give reps default scope so they don't pollute javadoc" (see: 765db3d).
Is this still a strong enough reason to make them default scoped? Is there something better we could do other than making reps public?
This change also makes
Variation<>public for similar reasons.Edit: Okay a bunch of other stuff fell forward with this change - I also made
Variations,TargetRules and their associated Builders public.Quite a bit ended up changing here - if wish to keep these package private I will perhaps look at other options to solve our use cases (like for example; adding a FeatureStore which takes a map of key values instead).