dr/v2 #54
dr/v2 #54
Conversation
…ork the same way it did before.
| } | ||
|
|
||
| dependencies { | ||
| compile "org.apache.httpcomponents:httpclient:4.3.6" |
There was a problem hiding this comment.
Updated all the deps to latest releases.
| * | ||
| * @param key the key of the feature flag to evaluate to true. | ||
| */ | ||
| public void setFeatureTrue(String key) { |
There was a problem hiding this comment.
I intended to keep the spirit of this class alive for true/false values, but renaming the on/off convention to true/false to avoid confusion with the fact that a flag can be on or off which may or may not yield true/false values.
| private boolean on; | ||
| private List<Prerequisite> prerequisites; | ||
| private String salt; | ||
| private String sel; |
There was a problem hiding this comment.
You can omit the sel since the server SDKs shouldn't need / see it.
| @@ -0,0 +1,14 @@ | |||
| package com.launchdarkly.client; | |||
|
|
|||
| public class Prerequisite { | |||
There was a problem hiding this comment.
Should not be public, and should not have public members.
|
Looking pretty good. Some comments to address before I thumb, but it's definitely coming together! |
|
@jkodumal if my recent commit looks good I'd like to merge this into the v2 branch as a wip- with this todo list: |
|
As long as you have all my comments captured as tasks in Asana or Todoist, that's fine. There are a number of them that are required work, not just minor cleanup (e.g. the scope / visibility issues of the data model classes). |
|
@jkodumal All your comments are addressed. The additional items are from me. |
|
Yep, I see that now-- other than shading Joda time, which looks like it should still be on your list. 👍 |
|
BTW, if you're going to shade joda-time, I would also suggest shading gson. I think we've discovered empirical evidence that version conflicts can lead to incorrect behavior. |
fix error in javadoc code sample
V2 support. This code passes integration harness tests.
A big part of the changes you see are a rename of FeatureRep->FeatureFlag
TODO: in a separate PR: local tests for prereq cycle detection