Update typings.d.ts #135
Merged
Update typings.d.ts #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `identify` return value to reflect updated API (promise now resolves w/ an `LDFlagSet`)
Contributor
|
Good catch. We thought we had done a thorough scan of all the declarations to make sure the types were up to date, but clearly missed that one - sorry. We'll try to get a patch out soon for this since it could affect usability for TS developers. |
eli-darkly
approved these changes
Feb 11, 2019
Merged
Contributor
|
This fix is included in the 2.9.3 release (2.9.2 was an error). |
Contributor
Author
|
Thanks for the quick turnaround! |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
identifyreturn value to reflect updated API (promise now resolves w/ anLDFlagSet)