prepare 2.9.4 release #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) create common package, move one file into it
(2) move entire client implementation into common package
(3) move references to doNotTrack and window.location.href into browser-specific code
(4) refactor config validation + make config available to platform client
5. move some usages of "window" into ldclient-js
6. move all goals logic into ldclient-js
7. move EventSource implementation into ldclient-js
ensure that build happens before publish for ldclient-react
…es (#157) * [ch31880] Initial commit * Update yarn.lock * Update initLDClient.test.ts * Update package-lock.json * Update package-lock.json
# Conflicts: # packages/ldclient-js-common/typings.d.ts # packages/ldclient-react/package-lock.json
(docs 1) improve TypeScript docs and add TypeDoc build script
(docs 2) fix TypeDoc build to include types from the common package
handle security error when we're not allowed to use window.localStorage
add release script that releases all packages in js-client
…dshake remove iframe handshake code for click event UI
fix error on out-of-order delete
change TS declarations to prefer interfaces over types
# Conflicts: # packages/ldclient-react/package-lock.json
atrakh
approved these changes
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.9.4] - 2019-02-22
Fixed:
window.localStorageexists). This was a long-standing problem, but became worse in the 2.9.0 release since the SDK now checks for browser capabilities like this regardless of whether you've attempted to use them yet. It should now simply log a warning if you try to usebootstrap: "localstorage"when local storage is disabled. (#138)privateAttributeNames, was not usable from TypeScript because it was omitted from the TypeScript declarations.interfacetotype. They all now useinterface, except forLDFlagValuewhich is a type alias. This should not affect regular usage of the SDK in TypeScript, but it is easier to extend aninterfacethan atypeif desired.