Added 'undefined' check on VERSION otherwise unbundled usage from npm fails #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 lgtm-- @apucacao ? |
Contributor
|
Thanks @yusinto! I had not thought of that. |
Contributor
Author
|
No worries! Happy to contribute! Thanks for the hard work guys |
apucacao
added a commit
that referenced
this pull request
Jan 19, 2018
respect "do not track" header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VERSION global variable gets injected by webpack for bundled versions of the client library. That is fine, however package.json "main" property is set to "src" which means usage through npm install references src/index.js which is unbundled. This fails with a ReferenceError to VERSION because index.js is unbundled.
I added a check for VERSION so this error can be avoided. If npm users need to find out the version of the client, they can do so via their app's package.json.