Add all_flags method to the client #22
Conversation
src/index.js
Outdated
| return value; | ||
| } | ||
|
|
||
| function all_flags() { |
There was a problem hiding this comment.
We should use allFlags which is more common in JS-land.
|
Can you explain why we decided not to always send events when calling all_flags? Also, in the server-side use case, when you say bootstrap, do you mean bootstrapping a client? |
|
I think you mis-read-- we always send events when calling all_flags here. In the server side case, yes-- bootstrapping a client is the most common use case. In that scenario, we don't want to send events for every feature flag. |
|
I was wondering why we didn't send events when calling all_flags on the server side. |
|
I think in the future we'll provide it as an option, but at the moment, if your only goal is to bootstrap the client-side JS, you don't want to trigger flag requests for every flag simply by bootstrapping. |
|
lgtm |
…rface-for-the-javascript [CH3359] Add Promise support for client initialization
This adds the all_flags method to the JS client. Unlike the server-side all_flags method, I've chosen to have this send analytics events.
The server-side use case is to bootstrap flags, so it doesn't necessarily make sense to send events there. Here, I think there's a stronger argument for sending the events. We might possibly want to make it an option, though?