chore: remove release-as override that caused duplicate 3.9.1 release#343
Merged
Merged
Conversation
The release-as: 3.9.1 field was added in #336 to force the first 3.9.1 release, but was not removed afterward. This caused release-please to create a second 3.9.1 release PR (#342), which failed because the tag already existed. This removes the override and cleans up the duplicate CHANGELOG entry. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
keelerm84
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
N/A — config-only change, no application code modified.
Related issues
The release workflow failed because release-please created a duplicate 3.9.1 release PR (#342) when the tag already existed from the first 3.9.1 release (#333).
Describe the solution you've provided
Removes the
release-as: "3.9.1"override fromrelease-please-config.jsonthat was added in #336. This override was intended as a one-time version force but was not cleaned up after the first 3.9.1 release shipped. When new commits (including #341) landed on main, release-please re-used the override and created a second 3.9.1 release PR (#342), which failed because the3.9.1tag already existed.Also removes the duplicate 3.9.1 CHANGELOG entry (with the broken
compare/3.9.1...3.9.1link) that was added by #342.After this merges, release-please will correctly compute the next version based on conventional commits since the 3.9.1 tag.
Describe alternatives you've considered
N/A
Additional context
The
fix:commit from #341 (update launchdarkly-js-sdk-common to 5.8.1) was not included in the published 3.9.1 npm package. Once this config fix merges, release-please should create a 3.9.2 release PR that includes that change.Link to Devin session: https://app.devin.ai/sessions/3fa824bb54c44fecb407c8aa43e3f193
Requested by: @kinyoklion
Note
Low Risk
Config and changelog-only; no runtime SDK code changes.
Overview
Fixes a release-please misconfiguration that caused a second 3.9.1 release PR when commits landed after the real 3.9.1 tag already existed.
The PR removes the leftover
release-as: "3.9.1"entry fromrelease-please-config.json(a one-time override that was never cleared after the first 3.9.1 shipped). It also deletes the erroneous duplicate 3.9.1 block fromCHANGELOG.md(including the brokencompare/3.9.1...3.9.1link) that came from that failed release PR.After merge, release-please should pick the next version from conventional commits since 3.9.1 (e.g. 3.9.2 for the unreleased
js-sdk-commonbump).Reviewed by Cursor Bugbot for commit 28fe5fa. Bugbot is set up for automated code reviews on this repo. Configure here.