Skip to content

chore: remove release-as override that caused duplicate 3.9.1 release#343

Merged
kinyoklion merged 1 commit into
mainfrom
devin/1779812312-fix-release-please-config
May 26, 2026
Merged

chore: remove release-as override that caused duplicate 3.9.1 release#343
kinyoklion merged 1 commit into
mainfrom
devin/1779812312-fix-release-please-config

Conversation

@kinyoklion
Copy link
Copy Markdown
Member

@kinyoklion kinyoklion commented May 26, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

N/A — config-only change, no application code modified.

Related issues

The release workflow failed because release-please created a duplicate 3.9.1 release PR (#342) when the tag already existed from the first 3.9.1 release (#333).

Describe the solution you've provided

Removes the release-as: "3.9.1" override from release-please-config.json that was added in #336. This override was intended as a one-time version force but was not cleaned up after the first 3.9.1 release shipped. When new commits (including #341) landed on main, release-please re-used the override and created a second 3.9.1 release PR (#342), which failed because the 3.9.1 tag already existed.

Also removes the duplicate 3.9.1 CHANGELOG entry (with the broken compare/3.9.1...3.9.1 link) that was added by #342.

After this merges, release-please will correctly compute the next version based on conventional commits since the 3.9.1 tag.

Describe alternatives you've considered

N/A

Additional context

The fix: commit from #341 (update launchdarkly-js-sdk-common to 5.8.1) was not included in the published 3.9.1 npm package. Once this config fix merges, release-please should create a 3.9.2 release PR that includes that change.

Link to Devin session: https://app.devin.ai/sessions/3fa824bb54c44fecb407c8aa43e3f193
Requested by: @kinyoklion


Note

Low Risk
Config and changelog-only; no runtime SDK code changes.

Overview
Fixes a release-please misconfiguration that caused a second 3.9.1 release PR when commits landed after the real 3.9.1 tag already existed.

The PR removes the leftover release-as: "3.9.1" entry from release-please-config.json (a one-time override that was never cleared after the first 3.9.1 shipped). It also deletes the erroneous duplicate 3.9.1 block from CHANGELOG.md (including the broken compare/3.9.1...3.9.1 link) that came from that failed release PR.

After merge, release-please should pick the next version from conventional commits since 3.9.1 (e.g. 3.9.2 for the unreleased js-sdk-common bump).

Reviewed by Cursor Bugbot for commit 28fe5fa. Bugbot is set up for automated code reviews on this repo. Configure here.

The release-as: 3.9.1 field was added in #336 to force the first 3.9.1
release, but was not removed afterward. This caused release-please to
create a second 3.9.1 release PR (#342), which failed because the tag
already existed.

This removes the override and cleans up the duplicate CHANGELOG entry.

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@kinyoklion kinyoklion marked this pull request as ready for review May 26, 2026 16:20
@kinyoklion kinyoklion requested a review from a team as a code owner May 26, 2026 16:20
@kinyoklion kinyoklion merged commit f77c17d into main May 26, 2026
11 checks passed
@kinyoklion kinyoklion deleted the devin/1779812312-fix-release-please-config branch May 26, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants