Refactored waitUntilReady() to always resolve even after ready event was already emitted
#66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2018 09:33
The current `waitUntilReady()` method will never resolve if the 'ready' event fires after the client's code is run. This implementation will maintain the state of the promise and will always resolve even after the 'ready' event was emitted.
rmanalan
changed the title
waitUntilReady()waitUntilReady() to always resolve even after ready event was already emitted
apucacao
approved these changes
Feb 7, 2018
Contributor
apucacao
left a comment
apucacao
left a comment
There was a problem hiding this comment.
This look great — thanks Rich! 😄
Contributor
|
This will go out with our next release, which should come out shortly. |
eli-darkly
added a commit
that referenced
this pull request
May 26, 2018
better handling of null/invalid user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
waitUntilReady()method will never resolve if the 'ready' event fires after the client's code is run. This implementation will maintain the state of the promise and will always resolve even after the 'ready' event was emitted.