Skip to content

Conversation

@brooswit
Copy link
Contributor

@brooswit brooswit commented Apr 9, 2018

No description provided.

Copy link

@sarahlessner sarahlessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


You can find a graph showing browser promises support [here](https://caniuse.com/#feat=promises).

You can load the polyfll via a script tag in the `<head>`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo- polyfll -> polyfill


\* These browsers do not support streaming new flags to connected clients, even when `client.on('change')` is called.

### Promies polyfill
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Promies

@eli-darkly
Copy link
Contributor

Isn't this somewhat contradicted by the other PR? I mean, it looks like we are saying that they should include something like es6-promise, but then we are automatically loading es6-promise anyway.

@brooswit brooswit closed this Apr 9, 2018
@brooswit brooswit deleted the jw/ch13299 branch April 9, 2018 21:33
apucacao added a commit that referenced this pull request Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants