fix: Fix an issue where failed http requests could cause an unhandled promise rejection. #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #232944: LaunchDarkly node-server-sdk is crashing node process due to unhandled promise. |
kinyoklion
requested review from
louis-launchdarkly and
yusinto
as code owners
yusinto
approved these changes
Feb 12, 2024
Contributor
yusinto
left a comment
yusinto
left a comment
There was a problem hiding this comment.
Minor comment on string includes.
packages/sdk/server-node/__tests__/platform/NodeRequests.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com>
kinyoklion
pushed a commit
that referenced
this pull request
Feb 12, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>node-server-sdk: 8.2.5</summary> ## [8.2.5](node-server-sdk-v8.2.4...node-server-sdk-v8.2.5) (2024-02-12) ### Bug Fixes * Fix an issue where failed http requests could cause an unhandled promise rejection. ([#374](#374)) ([ecfd2db](ecfd2db)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick from the 9.x release.