fix: Fix an issue where failed http requests could cause an unhandled promise rejection. #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #232944: LaunchDarkly node-server-sdk is crashing node process due to unhandled promise. |
kinyoklion
commented
Feb 8, 2024
| expect(serverResult.headers['sample-header']).toEqual('Some header value'); | ||
| }); | ||
|
|
||
| it('rejection is handled for response even if not awaited', async () => { |
Member
Author
There was a problem hiding this comment.
Running this test against the original code will fail, against this code it works.
kinyoklion
commented
Feb 8, 2024
|
|
||
| status: number; | ||
|
|
||
| listened: boolean = false; |
Member
Author
There was a problem hiding this comment.
Basically we don't attempt to read the body from all HTTP requests we make. Event posting doesn't return a body, so we discard the inner response.
Unfortunately that inner response may still be rejected.
So we track if the promise has been listened to. If it has been, then we reject like normal. If not we cache the rejection error and throw it when someone listens to the promise.
kinyoklion
requested review from
louis-launchdarkly and
yusinto
as code owners
yusinto
approved these changes
Feb 8, 2024
Merged
kinyoklion
added a commit
that referenced
this pull request
Feb 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>node-server-sdk: 9.1.1</summary> ## [9.1.1](node-server-sdk-v9.1.0...node-server-sdk-v9.1.1) (2024-02-08) ### Bug Fixes * Fix an issue where failed http requests could cause an unhandled promise rejection. ([#371](#371)) ([dd6d0e7](dd6d0e7)) </details> <details><summary>node-server-sdk-dynamodb: 6.1.1</summary> ## [6.1.1](node-server-sdk-dynamodb-v6.1.0...node-server-sdk-dynamodb-v6.1.1) (2024-02-08) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.1.0 to 9.1.1 * peerDependencies * @launchdarkly/node-server-sdk bumped from 9.0.6 to 9.1.1 </details> <details><summary>node-server-sdk-redis: 4.1.1</summary> ## [4.1.1](node-server-sdk-redis-v4.1.0...node-server-sdk-redis-v4.1.1) (2024-02-08) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.1.0 to 9.1.1 * peerDependencies * @launchdarkly/node-server-sdk bumped from 9.0.6 to 9.1.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #370