ci: workaround contract test failure #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@launchdarkly/js-sdk-common size report |
joker23
force-pushed
the
skz/fix-contract-test
branch
from
e358460 to
829383e
Compare
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
tanderson-ld
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: CI-only change that pins an external test harness commit; main risk is future brittleness if the pinned SHA becomes incompatible or is removed.
Overview
Pins the
sdk-test-harnessused by the server-node CI contract tests to a specific commit SHA instead of checking outfeat/fdv2, with inline comments noting this as a temporary workaround for upstream harness changes (SDK-1798). This stabilizes contract test runs until the SDK supports the newer harness requirements.Written by Cursor Bugbot for commit 829383e. This will update automatically on new commits. Configure here.