Skip to content

Conversation

@yusinto
Copy link
Contributor

@yusinto yusinto commented May 5, 2023

This supersedes earlier prs to add a vercel example because:

  1. Package linking via yarn workspace works now.
  2. This uses the new EdgeFeatureStore class.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #199365: Add vercel example.

@yusinto yusinto requested review from ldhenry and monsagri May 5, 2023 05:53
@yusinto
Copy link
Contributor Author

yusinto commented May 5, 2023

@monsagri are you able to compare this example app with your private one to debug the package.json issue?

@yusinto yusinto mentioned this pull request May 5, 2023
Copy link
Contributor

@louis-launchdarkly louis-launchdarkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have vercel to run this, but the code looks fine and the build is green. You may want to wait for another Approval if you want someone who have more JavaScript experience reviewing this.

@yusinto
Copy link
Contributor Author

yusinto commented May 9, 2023

Ta @louis-launchdarkly this is just an example app and I think it's ok to merge now for the benefit of our customers. I tested this thoroughly so it should be ok. We can fix issues as they arise. Thank you!

@yusinto yusinto merged commit 40c5d51 into main May 9, 2023
@yusinto yusinto deleted the yus/sc-199365/may-5-vercel-example branch May 9, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants