refactor: remove contract test got dependency#1188
Merged
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
293f632 to
fd37415
Compare
fd37415 to
dc6dcf6
Compare
Contributor
Author
Contributor
Author
|
@cursor review |
kinyoklion
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk because changes are limited to contract-test helpers and build/lint configuration; main risk is contract tests failing in environments without a compatible global
fetchimplementation.Overview
Contract-test HTTP calls now use
fetchinstead ofgot, including big segment store callbacks, migration endpoint invocations, andregisterFlagChangeListenernotifications, with basicresponse.ok/status error handling.Removes
gotfromcontract-tests/package.jsonand@launchdarkly/js-contract-test-utilspeer/dev dependencies, and drops thetsconfig.server.jsonpath alias that existed to makegotresolvable under ESM.Adds a
server-node.eslintrc.cjsoverride forcontract-tests/**/*.ts, and adjuststsconfig.eslint.jsonincludes/excludes to avoid lintingdistandcontract-testsby default.Written by Cursor Bugbot for commit b4396a9. This will update automatically on new commits. Configure here.