Skip to content

refactor: remove contract test got dependency#1188

Merged
joker23 merged 3 commits intomainfrom
skz/sdk-2029/replace-got-package
Mar 17, 2026
Merged

refactor: remove contract test got dependency#1188
joker23 merged 3 commits intomainfrom
skz/sdk-2029/replace-got-package

Conversation

@joker23
Copy link
Contributor

@joker23 joker23 commented Mar 13, 2026

Note

Low Risk
Low risk because changes are limited to contract-test helpers and build/lint configuration; main risk is contract tests failing in environments without a compatible global fetch implementation.

Overview
Contract-test HTTP calls now use fetch instead of got, including big segment store callbacks, migration endpoint invocations, and registerFlagChangeListener notifications, with basic response.ok/status error handling.

Removes got from contract-tests/package.json and @launchdarkly/js-contract-test-utils peer/dev dependencies, and drops the tsconfig.server.json path alias that existed to make got resolvable under ESM.

Adds a server-node .eslintrc.cjs override for contract-tests/**/*.ts, and adjusts tsconfig.eslint.json includes/excludes to avoid linting dist and contract-tests by default.

Written by Cursor Bugbot for commit b4396a9. This will update automatically on new commits. Configure here.


Open with Devin

@github-actions
Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25566 bytes
Compressed size limit: 26000
Uncompressed size: 125383 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 24539 bytes
Compressed size limit: 25000
Uncompressed size: 85098 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 172527 bytes
Compressed size limit: 200000
Uncompressed size: 802217 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 22203 bytes
Compressed size limit: 24000
Uncompressed size: 115238 bytes

@joker23 joker23 force-pushed the skz/sdk-2029/replace-got-package branch from 293f632 to fd37415 Compare March 14, 2026 03:16
@joker23 joker23 force-pushed the skz/sdk-2029/replace-got-package branch from fd37415 to dc6dcf6 Compare March 14, 2026 03:50
@joker23
Copy link
Contributor Author

joker23 commented Mar 16, 2026

@cursor review
@devin review

cursor[bot]

This comment was marked as resolved.

@joker23
Copy link
Contributor Author

joker23 commented Mar 16, 2026

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@joker23 joker23 marked this pull request as ready for review March 16, 2026 19:03
@joker23 joker23 requested a review from a team as a code owner March 16, 2026 19:03
@joker23 joker23 merged commit bdaee5d into main Mar 17, 2026
44 of 47 checks passed
@joker23 joker23 deleted the skz/sdk-2029/replace-got-package branch March 17, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants