feat: Adding CreatePlatformInfo for Akamai SDK #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…994/create-platform-class-to-be-used-by-the-sdk
|
This pull request has been linked to Shortcut Story #203994: Create platform class to be used by the SDK. |
dariushar
changed the title
dariushar
requested review from
kinyoklion,
louis-launchdarkly and
yusinto
as code owners
ctawiah
approved these changes
May 25, 2023
Contributor
ctawiah
left a comment
ctawiah
left a comment
There was a problem hiding this comment.
LGTM. Can you update the SDK name in package.json to @launchdarkly/akamai-edgeworker-sdk?
ctawiah
approved these changes
May 25, 2023
dariushar
deleted the
dariusharrison/sc-203994/create-platform-class-to-be-used-by-the-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Create platform class and test for the Akamai SDK
Added
@launchdarkly/js-server-sdk-common-edgedependencyRemoved unnecessary file inclusion from tsconfig