chore: remove trackJudgeResult from graph tracker and fix judgeConfigKey spread#1296
Merged
jsonbailey merged 1 commit intofeat/ai-sdk-next-releasefrom Apr 20, 2026
Merged
Conversation
…Key spread Removes trackJudgeResult from LDGraphTracker interface and LDGraphTrackerImpl — it belongs only on the config tracker. Also fixes LDAIConfigTrackerImpl to conditionally include judgeConfigKey rather than spreading undefined.
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
approved these changes
Apr 20, 2026
jsonbailey
added a commit
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trackJudgeResultfromLDGraphTrackerinterface andLDGraphTrackerImpl— it belongs only on the config trackerLDAIConfigTrackerImpl.trackJudgeResultto conditionally includejudgeConfigKeyrather than unconditionally spreading it (which emittedjudgeConfigKey: undefinedwhen absent)LDGraphTrackerImpl.test.tsTest plan
yarn workspace @launchdarkly/server-sdk-ai lintpassesyarn workspace @launchdarkly/server-sdk-ai testpasses (176 tests)Note
Medium Risk
Medium risk due to an API surface change:
trackJudgeResultis removed fromLDGraphTracker, which may break downstream callers. Behavioral change inLDAIConfigTrackerImpl.trackJudgeResultis small but affects emitted analytics payloads.Overview
Removes judge-result tracking from the graph tracker by deleting
trackJudgeResultfromLDGraphTrackerandLDGraphTrackerImpl, along with the correspondingLDGraphTrackerImpltests.Updates
LDAIConfigTrackerImpl.trackJudgeResultto only includejudgeConfigKeyin the tracked event data when it is present, avoiding emission ofjudgeConfigKey: undefined.Reviewed by Cursor Bugbot for commit bf71059. Bugbot is set up for automated code reviews on this repo. Configure here.