chore: remove _agentConfigInternal and use _agentConfig directly#1297
Merged
jsonbailey merged 1 commit intofeat/ai-sdk-next-releasefrom Apr 20, 2026
Merged
Conversation
Replaces the duplicate private method with a call to the existing _agentConfig, correcting the parameter order (graphKey, variables → variables, graphKey).
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
approved these changes
Apr 20, 2026
jsonbailey
added a commit
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_agentConfigInternalprivate method fromLDAIClientImpl_agentConfig(key, context, disabledAIConfig, variables, graphKey), correcting the parameter order (graphKey, variables→variables, graphKey)Test plan
yarn workspace @launchdarkly/server-sdk-ai lintpassesyarn workspace @launchdarkly/server-sdk-ai testpasses (181 tests)Note
Low Risk
Low risk refactor that removes a duplicate private helper and updates a single call site; behavior should remain the same aside from passing
graphKey/variablesin the correct order.Overview
Simplifies
LDAIClientImplby deleting the redundant private_agentConfigInternalhelper and havingagentGraphcall_agentConfigdirectly.This also fixes the argument ordering for the internal agent-config fetch in
agentGraph(passingvariablesbeforegraphKey) so configs are evaluated with the intended interpolation variables and graph tracking context.Reviewed by Cursor Bugbot for commit 0670ad5. Bugbot is set up for automated code reviews on this repo. Configure here.