Skip to content

fix: enabling eslint ban-types rule and fixed string typing#1313

Merged
joker23 merged 1 commit intomainfrom
skz/sdk-2230/reenable-eslint-rules
Apr 24, 2026
Merged

fix: enabling eslint ban-types rule and fixed string typing#1313
joker23 merged 1 commit intomainfrom
skz/sdk-2230/reenable-eslint-rules

Conversation

@joker23
Copy link
Copy Markdown
Contributor

@joker23 joker23 commented Apr 23, 2026

This PR reenables the ban-type eslint rule. This results in:

  • a fix to a pre-existing typing bug where String type should be string
  • a more defined Function typing

Open in Devin Review

Note

Low Risk
Mostly TypeScript typing/lint-only changes (replacing Function/String with safer types) with minimal runtime impact; risk is limited to potential downstream type incompatibilities in event listener signatures.

Overview
Re-enables stricter TypeScript linting around banned types by removing the global @typescript-eslint/ban-types opt-out and adding targeted suppressions where Function return types are required (e.g. listeners()/rawListeners()).

Tightens public and test-facing callback typings across clients/emitter APIs by replacing Function with (...args: any[]) => void, and fixes boxed String usages to primitive string in request bodies and transactional store selector parameters (plus deepCompact now constrains T to object).

Reviewed by Cursor Bugbot for commit 09ceb8c. Bugbot is set up for automated code reviews on this repo. Configure here.

@joker23 joker23 requested a review from a team as a code owner April 23, 2026 19:12
@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25623 bytes
Compressed size limit: 29000
Uncompressed size: 125843 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31858 bytes
Compressed size limit: 34000
Uncompressed size: 113634 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38473 bytes
Compressed size limit: 39000
Uncompressed size: 211104 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179574 bytes
Compressed size limit: 200000
Uncompressed size: 830815 bytes

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@joker23 joker23 force-pushed the skz/sdk-2230/reenable-eslint-rules branch from a151817 to 09ceb8c Compare April 24, 2026 14:27
@joker23 joker23 merged commit f6d907f into main Apr 24, 2026
45 checks passed
@joker23 joker23 deleted the skz/sdk-2230/reenable-eslint-rules branch April 24, 2026 15:31
@github-actions github-actions Bot mentioned this pull request Apr 24, 2026
joker23 pushed a commit that referenced this pull request Apr 24, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>akamai-edgeworker-sdk-common: 2.0.19</summary>

##
[2.0.19](akamai-edgeworker-sdk-common-v2.0.18...akamai-edgeworker-sdk-common-v2.0.19)
(2026-04-24)


### Bug Fixes

* enabling eslint `ban-types` rule and fixed string typing
([#1313](#1313))
([f6d907f](f6d907f))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from ^2.18.4 to ^2.18.5
</details>

<details><summary>akamai-server-base-sdk: 3.0.20</summary>

##
[3.0.20](akamai-server-base-sdk-v3.0.19...akamai-server-base-sdk-v3.0.20)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^2.0.18 to
^2.0.19
    * @launchdarkly/js-server-sdk-common bumped from ^2.18.4 to ^2.18.5
</details>

<details><summary>akamai-server-edgekv-sdk: 1.4.22</summary>

##
[1.4.22](akamai-server-edgekv-sdk-v1.4.21...akamai-server-edgekv-sdk-v1.4.22)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^2.0.18 to
^2.0.19
    * @launchdarkly/js-server-sdk-common bumped from ^2.18.4 to ^2.18.5
</details>

<details><summary>browser: 0.1.18</summary>

##
[0.1.18](browser-v0.1.17...browser-v0.1.18)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk bumped from 4.6.2 to 4.6.3
</details>

<details><summary>cloudflare-server-sdk: 2.7.21</summary>

##
[2.7.21](cloudflare-server-sdk-v2.7.20...cloudflare-server-sdk-v2.7.21)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/js-server-sdk-common-edge bumped from 2.6.17 to 2.6.18
</details>

<details><summary>fastly-server-sdk: 0.2.11</summary>

##
[0.2.11](fastly-server-sdk-v0.2.10...fastly-server-sdk-v0.2.11)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5
</details>

<details><summary>jest: 1.0.12</summary>

##
[1.0.12](jest-v1.0.11...jest-v1.0.12)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/react-native-client-sdk bumped from ~10.17.0 to ~10.17.1
</details>

<details><summary>js-client-sdk: 4.6.3</summary>

##
[4.6.3](js-client-sdk-v4.6.2...js-client-sdk-v4.6.3)
(2026-04-24)


### Bug Fixes

* enabling eslint `ban-types` rule and fixed string typing
([#1313](#1313))
([f6d907f](f6d907f))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk-common bumped from 1.26.0 to 1.26.1
</details>

<details><summary>js-client-sdk-common: 1.26.1</summary>

##
[1.26.1](js-client-sdk-common-v1.26.0...js-client-sdk-common-v1.26.1)
(2026-04-24)


### Bug Fixes

* enabling eslint `ban-types` rule and fixed string typing
([#1313](#1313))
([f6d907f](f6d907f))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-sdk-common bumped from 2.24.1 to 2.24.2
</details>

<details><summary>js-sdk-common: 2.24.2</summary>

##
[2.24.2](js-sdk-common-v2.24.1...js-sdk-common-v2.24.2)
(2026-04-24)


### Bug Fixes

* enabling eslint `ban-types` rule and fixed string typing
([#1313](#1313))
([f6d907f](f6d907f))
</details>

<details><summary>js-server-sdk-common: 2.18.5</summary>

##
[2.18.5](js-server-sdk-common-v2.18.4...js-server-sdk-common-v2.18.5)
(2026-04-24)


### Bug Fixes

* enabling eslint `ban-types` rule and fixed string typing
([#1313](#1313))
([f6d907f](f6d907f))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-sdk-common bumped from 2.24.1 to 2.24.2
</details>

<details><summary>js-server-sdk-common-edge: 2.6.18</summary>

##
[2.6.18](js-server-sdk-common-edge-v2.6.17...js-server-sdk-common-edge-v2.6.18)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5
</details>

<details><summary>node-server-sdk: 9.10.12</summary>

##
[9.10.12](node-server-sdk-v9.10.11...node-server-sdk-v9.10.12)
(2026-04-24)


### Bug Fixes

* enabling eslint `ban-types` rule and fixed string typing
([#1313](#1313))
([f6d907f](f6d907f))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5
</details>

<details><summary>node-server-sdk-dynamodb: 6.2.25</summary>

##
[6.2.25](node-server-sdk-dynamodb-v6.2.24...node-server-sdk-dynamodb-v6.2.25)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.10.11 to 9.10.12
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.10.12
</details>

<details><summary>node-server-sdk-otel: 1.3.12</summary>

##
[1.3.12](node-server-sdk-otel-v1.3.11...node-server-sdk-otel-v1.3.12)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.10.11 to 9.10.12
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.10.12
</details>

<details><summary>node-server-sdk-redis: 4.2.24</summary>

##
[4.2.24](node-server-sdk-redis-v4.2.23...node-server-sdk-redis-v4.2.24)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.10.11 to 9.10.12
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.10.12
</details>

<details><summary>react-native-client-sdk: 10.17.1</summary>

##
[10.17.1](react-native-client-sdk-v10.17.0...react-native-client-sdk-v10.17.1)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk-common bumped from 1.26.0 to 1.26.1
</details>

<details><summary>react-sdk: 0.2.4</summary>

##
[0.2.4](react-sdk-v0.2.3...react-sdk-v0.2.4)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk bumped from ^4.6.2 to ^4.6.3
    * @launchdarkly/js-server-sdk-common bumped from ^2.18.4 to ^2.18.5
</details>

<details><summary>server-sdk-ai: 0.17.1</summary>

##
[0.17.1](server-sdk-ai-v0.17.0...server-sdk-ai-v0.17.1)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5
  * peerDependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.x to 2.18.5
</details>

<details><summary>server-sdk-ai-langchain: 0.5.6</summary>

##
[0.5.6](server-sdk-ai-langchain-v0.5.5...server-sdk-ai-langchain-v0.5.6)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1
  * peerDependencies
    * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1
</details>

<details><summary>server-sdk-ai-openai: 0.5.6</summary>

##
[0.5.6](server-sdk-ai-openai-v0.5.5...server-sdk-ai-openai-v0.5.6)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5
    * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1
  * peerDependencies
    * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1
</details>

<details><summary>server-sdk-ai-vercel: 0.5.6</summary>

##
[0.5.6](server-sdk-ai-vercel-v0.5.5...server-sdk-ai-vercel-v0.5.6)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1
  * peerDependencies
    * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1
</details>

<details><summary>shopify-oxygen-sdk: 0.1.9</summary>

##
[0.1.9](shopify-oxygen-sdk-v0.1.8...shopify-oxygen-sdk-v0.1.9)
(2026-04-24)


### Bug Fixes

* enabling eslint `ban-types` rule and fixed string typing
([#1313](#1313))
([f6d907f](f6d907f))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5
</details>

<details><summary>vercel-server-sdk: 1.3.44</summary>

##
[1.3.44](vercel-server-sdk-v1.3.43...vercel-server-sdk-v1.3.44)
(2026-04-24)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/js-server-sdk-common-edge bumped from 2.6.17 to 2.6.18
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: this is primarily a Release Please version bump across many
packages plus dependency range updates, with only minor constant/version
string updates in a few SDK info helpers.
> 
> **Overview**
> This PR is an automated release cut that **bumps versions and
regenerates changelogs** across the monorepo (AI providers,
browser/server SDKs, edge runtimes, stores, telemetry, and tooling) and
updates `.release-please-manifest.json` accordingly.
> 
> It also updates internal workspace dependency pins (notably
`@launchdarkly/js-server-sdk-common`,
`@launchdarkly/js-client-sdk-common`, and `@launchdarkly/server-sdk-ai`)
and refreshes embedded `sdkVersion`/`wrapperVersion` constants in a
handful of platform info files (e.g. `BrowserInfo`, `NodeInfo`,
`createPlatformInfo`).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
fe3982c. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants