fix: enabling eslint ban-types rule and fixed string typing#1313
Merged
fix: enabling eslint ban-types rule and fixed string typing#1313
ban-types rule and fixed string typing#1313Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
kinyoklion
approved these changes
Apr 23, 2026
a151817 to
09ceb8c
Compare
Merged
joker23
pushed a commit
that referenced
this pull request
Apr 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>akamai-edgeworker-sdk-common: 2.0.19</summary> ## [2.0.19](akamai-edgeworker-sdk-common-v2.0.18...akamai-edgeworker-sdk-common-v2.0.19) (2026-04-24) ### Bug Fixes * enabling eslint `ban-types` rule and fixed string typing ([#1313](#1313)) ([f6d907f](f6d907f)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from ^2.18.4 to ^2.18.5 </details> <details><summary>akamai-server-base-sdk: 3.0.20</summary> ## [3.0.20](akamai-server-base-sdk-v3.0.19...akamai-server-base-sdk-v3.0.20) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^2.0.18 to ^2.0.19 * @launchdarkly/js-server-sdk-common bumped from ^2.18.4 to ^2.18.5 </details> <details><summary>akamai-server-edgekv-sdk: 1.4.22</summary> ## [1.4.22](akamai-server-edgekv-sdk-v1.4.21...akamai-server-edgekv-sdk-v1.4.22) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^2.0.18 to ^2.0.19 * @launchdarkly/js-server-sdk-common bumped from ^2.18.4 to ^2.18.5 </details> <details><summary>browser: 0.1.18</summary> ## [0.1.18](browser-v0.1.17...browser-v0.1.18) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk bumped from 4.6.2 to 4.6.3 </details> <details><summary>cloudflare-server-sdk: 2.7.21</summary> ## [2.7.21](cloudflare-server-sdk-v2.7.20...cloudflare-server-sdk-v2.7.21) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.6.17 to 2.6.18 </details> <details><summary>fastly-server-sdk: 0.2.11</summary> ## [0.2.11](fastly-server-sdk-v0.2.10...fastly-server-sdk-v0.2.11) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5 </details> <details><summary>jest: 1.0.12</summary> ## [1.0.12](jest-v1.0.11...jest-v1.0.12) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/react-native-client-sdk bumped from ~10.17.0 to ~10.17.1 </details> <details><summary>js-client-sdk: 4.6.3</summary> ## [4.6.3](js-client-sdk-v4.6.2...js-client-sdk-v4.6.3) (2026-04-24) ### Bug Fixes * enabling eslint `ban-types` rule and fixed string typing ([#1313](#1313)) ([f6d907f](f6d907f)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.26.0 to 1.26.1 </details> <details><summary>js-client-sdk-common: 1.26.1</summary> ## [1.26.1](js-client-sdk-common-v1.26.0...js-client-sdk-common-v1.26.1) (2026-04-24) ### Bug Fixes * enabling eslint `ban-types` rule and fixed string typing ([#1313](#1313)) ([f6d907f](f6d907f)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.24.1 to 2.24.2 </details> <details><summary>js-sdk-common: 2.24.2</summary> ## [2.24.2](js-sdk-common-v2.24.1...js-sdk-common-v2.24.2) (2026-04-24) ### Bug Fixes * enabling eslint `ban-types` rule and fixed string typing ([#1313](#1313)) ([f6d907f](f6d907f)) </details> <details><summary>js-server-sdk-common: 2.18.5</summary> ## [2.18.5](js-server-sdk-common-v2.18.4...js-server-sdk-common-v2.18.5) (2026-04-24) ### Bug Fixes * enabling eslint `ban-types` rule and fixed string typing ([#1313](#1313)) ([f6d907f](f6d907f)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.24.1 to 2.24.2 </details> <details><summary>js-server-sdk-common-edge: 2.6.18</summary> ## [2.6.18](js-server-sdk-common-edge-v2.6.17...js-server-sdk-common-edge-v2.6.18) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5 </details> <details><summary>node-server-sdk: 9.10.12</summary> ## [9.10.12](node-server-sdk-v9.10.11...node-server-sdk-v9.10.12) (2026-04-24) ### Bug Fixes * enabling eslint `ban-types` rule and fixed string typing ([#1313](#1313)) ([f6d907f](f6d907f)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5 </details> <details><summary>node-server-sdk-dynamodb: 6.2.25</summary> ## [6.2.25](node-server-sdk-dynamodb-v6.2.24...node-server-sdk-dynamodb-v6.2.25) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.10.11 to 9.10.12 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.10.12 </details> <details><summary>node-server-sdk-otel: 1.3.12</summary> ## [1.3.12](node-server-sdk-otel-v1.3.11...node-server-sdk-otel-v1.3.12) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.10.11 to 9.10.12 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.10.12 </details> <details><summary>node-server-sdk-redis: 4.2.24</summary> ## [4.2.24](node-server-sdk-redis-v4.2.23...node-server-sdk-redis-v4.2.24) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.10.11 to 9.10.12 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.10.12 </details> <details><summary>react-native-client-sdk: 10.17.1</summary> ## [10.17.1](react-native-client-sdk-v10.17.0...react-native-client-sdk-v10.17.1) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.26.0 to 1.26.1 </details> <details><summary>react-sdk: 0.2.4</summary> ## [0.2.4](react-sdk-v0.2.3...react-sdk-v0.2.4) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk bumped from ^4.6.2 to ^4.6.3 * @launchdarkly/js-server-sdk-common bumped from ^2.18.4 to ^2.18.5 </details> <details><summary>server-sdk-ai: 0.17.1</summary> ## [0.17.1](server-sdk-ai-v0.17.0...server-sdk-ai-v0.17.1) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5 * peerDependencies * @launchdarkly/js-server-sdk-common bumped from 2.x to 2.18.5 </details> <details><summary>server-sdk-ai-langchain: 0.5.6</summary> ## [0.5.6](server-sdk-ai-langchain-v0.5.5...server-sdk-ai-langchain-v0.5.6) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1 </details> <details><summary>server-sdk-ai-openai: 0.5.6</summary> ## [0.5.6](server-sdk-ai-openai-v0.5.5...server-sdk-ai-openai-v0.5.6) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5 * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1 </details> <details><summary>server-sdk-ai-vercel: 0.5.6</summary> ## [0.5.6](server-sdk-ai-vercel-v0.5.5...server-sdk-ai-vercel-v0.5.6) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.17.0 to ^0.17.1 </details> <details><summary>shopify-oxygen-sdk: 0.1.9</summary> ## [0.1.9](shopify-oxygen-sdk-v0.1.8...shopify-oxygen-sdk-v0.1.9) (2026-04-24) ### Bug Fixes * enabling eslint `ban-types` rule and fixed string typing ([#1313](#1313)) ([f6d907f](f6d907f)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.4 to 2.18.5 </details> <details><summary>vercel-server-sdk: 1.3.44</summary> ## [1.3.44](vercel-server-sdk-v1.3.43...vercel-server-sdk-v1.3.44) (2026-04-24) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.6.17 to 2.6.18 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this is primarily a Release Please version bump across many packages plus dependency range updates, with only minor constant/version string updates in a few SDK info helpers. > > **Overview** > This PR is an automated release cut that **bumps versions and regenerates changelogs** across the monorepo (AI providers, browser/server SDKs, edge runtimes, stores, telemetry, and tooling) and updates `.release-please-manifest.json` accordingly. > > It also updates internal workspace dependency pins (notably `@launchdarkly/js-server-sdk-common`, `@launchdarkly/js-client-sdk-common`, and `@launchdarkly/server-sdk-ai`) and refreshes embedded `sdkVersion`/`wrapperVersion` constants in a handful of platform info files (e.g. `BrowserInfo`, `NodeInfo`, `createPlatformInfo`). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit fe3982c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reenables the ban-type eslint rule. This results in:
Stringtype should bestringFunctiontypingNote
Low Risk
Mostly TypeScript typing/lint-only changes (replacing
Function/Stringwith safer types) with minimal runtime impact; risk is limited to potential downstream type incompatibilities in event listener signatures.Overview
Re-enables stricter TypeScript linting around banned types by removing the global
@typescript-eslint/ban-typesopt-out and adding targeted suppressions whereFunctionreturn types are required (e.g.listeners()/rawListeners()).Tightens public and test-facing callback typings across clients/emitter APIs by replacing
Functionwith(...args: any[]) => void, and fixes boxedStringusages to primitivestringin request bodies and transactional storeselectorparameters (plusdeepCompactnow constrainsTtoobject).Reviewed by Cursor Bugbot for commit 09ceb8c. Bugbot is set up for automated code reviews on this repo. Configure here.