feat: fall back to model.parameters.tools when root tools absent by jsonbailey · Pull Request #1330 · launchdarkly/js-core

jsonbailey · 2026-04-28T22:38:44Z

Summary

Adds _resolveTools() to LDAIConfigUtils — checks root-level tools first, falls back to model.parameters.tools for older AI configs
Root-level tools always takes priority when present
model.parameters.tools as an array or non-object is silently ignored (may be user-defined custom param)
Entries missing a name string are silently skipped; valid entries in the same map are still returned

Background

The LaunchDarkly AI Config API now sends tools in two places: updated configs send them at both root and model.parameters.tools; older configs only send them in model.parameters.tools. Previously the SDK only read root-level, leaving older configs with no tools.

Test plan

Existing tools tests pass
Tools parsed from model.parameters.tools when root key is absent
Root tools wins when both locations are present
model.parameters.tools as array → undefined
Entries missing name skipped; valid entries in same map returned

Jira: AIC-1935

🤖 Generated with Claude Code

Note

Medium Risk
Changes how tools are derived for agent/completion configs by adding a fallback to model.parameters.tools and new validation/logging, which could alter runtime tool availability for existing flags.

Overview
Adds a new tool-resolution path for AI configs: tools are now taken from the root-level tools map when present, otherwise parsed from model.parameters.tools to support older flag shapes.

Tool parsing now validates that tools are object maps (not arrays/invalid types), normalizes entries (including defaulting missing name to the map key), and emits warnings via an optionally passed logger. Tests were expanded to cover the fallback, precedence rules, and invalid-shape handling.

^{Reviewed by Cursor Bugbot for commit edcee1d. Bugbot is set up for automated code reviews on this repo. Configure here.}

When root-level tools is absent, fall back to model.parameters.tools and parse it as our LDTool map format. Arrays or entries missing a name field are silently ignored. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions · 2026-04-28T22:40:14Z

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25623 bytes
Compressed size limit: 29000
Uncompressed size: 125843 bytes

github-actions · 2026-04-28T22:40:37Z

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38473 bytes
Compressed size limit: 39000
Uncompressed size: 211104 bytes

github-actions · 2026-04-28T22:40:38Z

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31866 bytes
Compressed size limit: 34000
Uncompressed size: 113634 bytes

github-actions · 2026-04-28T22:40:39Z

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179311 bytes
Compressed size limit: 200000
Uncompressed size: 830815 bytes

…s bad entries Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…root tools path, fall back to key name when name field absent Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 76068a6. Configure here.}

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

joker23

1 nit comment

Add type guards for the parameters and customParameters fields in _parseToolsMap, consistent with existing guards on name, description, and type. Blind casts are replaced with null/object/array checks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

🤖 I have created a release *beep* *boop* --- <details><summary>server-sdk-ai: 0.19.0</summary> ## [0.19.0](server-sdk-ai-v0.18.1...server-sdk-ai-v0.19.0) (2026-05-01) ### Features * Support fall back to model.parameters.tools when root tools absent ([#1330](#1330)) ([2c65c61](2c65c61)) </details> <details><summary>server-sdk-ai-langchain: 0.6.2</summary> ## [0.6.2](server-sdk-ai-langchain-v0.6.1...server-sdk-ai-langchain-v0.6.2) (2026-05-01) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.18.1 to ^0.19.0 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.18.1 to ^0.19.0 </details> <details><summary>server-sdk-ai-openai: 0.5.9</summary> ## [0.5.9](server-sdk-ai-openai-v0.5.8...server-sdk-ai-openai-v0.5.9) (2026-05-01) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.18.1 to ^0.19.0 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.18.1 to ^0.19.0 </details> <details><summary>server-sdk-ai-vercel: 0.5.9</summary> ## [0.5.9](server-sdk-ai-vercel-v0.5.8...server-sdk-ai-vercel-v0.5.9) (2026-05-01) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.18.1 to ^0.19.0 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.18.1 to ^0.19.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).  --- > [!NOTE] > **Medium Risk** > Primarily a release/version-bump PR, but it publishes `@launchdarkly/server-sdk-ai@0.19.0` which changes runtime behavior around tool configuration fallback and could affect downstream integrations. > > **Overview** > Updates the release manifest and bumps versions for `@launchdarkly/server-sdk-ai` to `0.19.0` and its provider packages (`server-sdk-ai-langchain` `0.6.2`, `server-sdk-ai-openai` `0.5.9`, `server-sdk-ai-vercel` `0.5.9`). > > Propagates the new `@launchdarkly/server-sdk-ai@0.19.0` dependency range into provider `package.json` files and refreshes example app dependencies to the new package versions, along with changelog entries and the SDK version constant in `sdkInfo.ts`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ffc35f6. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>  Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Add model.parameters.tools fallback for tools resolution

d3c7256

When root-level tools is absent, fall back to model.parameters.tools and parse it as our LDTool map format. Arrays or entries missing a name field are silently ignored. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jsonbailey changed the title ~~feat(server-ai): fall back to model.parameters.tools when root tools absent~~ feat: fall back to model.parameters.tools when root tools absent Apr 28, 2026

jsonbailey and others added 4 commits April 29, 2026 10:08

fix: warn when model.parameters.tools is present but wrong type or ha…

ce1383e

…s bad entries Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: warn in _resolveTools when root tools is present but not an object

3bdde40

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: format warn call to satisfy prettier

b6a9ee4

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: extract _parseToolsMap helper, add per-entry validation to …

9ffc9b6

…root tools path, fall back to key name when name field absent Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jsonbailey marked this pull request as ready for review April 30, 2026 14:43

jsonbailey requested a review from a team as a code owner April 30, 2026 14:43

cursor Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread packages/sdk/server-ai/src/api/config/LDAIConfigUtils.ts

fix: guard against null root tools value in _resolveTools

76068a6

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cursor Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread packages/sdk/server-ai/src/api/config/LDAIConfigUtils.ts

fix: silently ignore model.parameters.tools when not an object

12815aa

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

joker23 approved these changes May 1, 2026

View reviewed changes

Comment thread packages/sdk/server-ai/src/api/config/LDAIConfigUtils.ts Outdated

jsonbailey changed the base branch from main to next-ai-release May 1, 2026 16:14

jsonbailey changed the base branch from next-ai-release to main May 1, 2026 16:14

joker23 approved these changes May 1, 2026

View reviewed changes

jsonbailey merged commit 2c65c61 into main May 1, 2026
43 checks passed

jsonbailey deleted the jb/aic-1935/tools-model-params-fallback branch May 1, 2026 17:11

github-actions Bot mentioned this pull request May 1, 2026

chore: release main #1348

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fall back to model.parameters.tools when root tools absent#1330

feat: fall back to model.parameters.tools when root tools absent#1330
jsonbailey merged 8 commits intomainfrom
jb/aic-1935/tools-model-params-fallback

jsonbailey commented Apr 28, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

joker23 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jsonbailey commented Apr 28, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Test plan

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joker23 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jsonbailey commented Apr 28, 2026 •

edited by cursor Bot

Loading

github-actions Bot commented Apr 28, 2026 •

edited

Loading

github-actions Bot commented Apr 28, 2026 •

edited

Loading