Skip to content

chore: remove unused dependencies across the monorepo#1752

Merged
joker23 merged 3 commits into
mainfrom
skz/sdk-2505/remove-unused-deps
Jun 24, 2026
Merged

chore: remove unused dependencies across the monorepo#1752
joker23 merged 3 commits into
mainfrom
skz/sdk-2505/remove-unused-deps

Conversation

@joker23

@joker23 joker23 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Low product risk if removals are truly unused, but incorrect drops (e.g. Vercel crypto-js, Akamai base transitive server-common, OpenFeature js-sdk-common) could break builds or published bundles until CI catches them.

Overview
Trims unused devDependencies and dependencies across many SDK, shared, store, and telemetry packages—most notably dropping launchdarkly-js-test-helpers where tests no longer import it, and removing Rollup/Jest/testing-library entries from packages that build or test with tsc, Vitest, or slimmer Jest setups.

A few runtime / packaging adjustments stand out: @launchdarkly/akamai-server-base-sdk no longer lists @launchdarkly/js-server-sdk-common (only the Akamai common package); @launchdarkly/vercel-server-sdk drops crypto-js; @launchdarkly/openfeature-node-server drops a direct @launchdarkly/js-sdk-common dependency; @launchdarkly/svelte-client-sdk pins @launchdarkly/js-client-sdk to 4.9.0 (replacing workspace:^) and removes esm-env plus unused Jest-oriented dev tooling.

release-please-config.json adds packages/sdk/svelte/package.json so @launchdarkly/js-client-sdk stays in sync when the browser SDK is released.

Reviewed by Cursor Bugbot for commit 58489a2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38739 bytes
Compressed size limit: 39000
Uncompressed size: 212244 bytes

},
"dependencies": {
"@launchdarkly/akamai-edgeworker-sdk-common": "^2.0.23",
"@launchdarkly/js-server-sdk-common": "^2.19.1"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a transitive dep of @launchdarkly/akamai-edgeworker-sdk-common

},
"devDependencies": {
"@eslint/js": "^9.0.0",
"@rollup/plugin-commonjs": "^25.0.0",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package uses tsc for build.

@joker23 joker23 marked this pull request as ready for review June 16, 2026 20:19
@joker23 joker23 requested a review from a team as a code owner June 16, 2026 20:19

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Comment thread packages/sdk/react-native/jest.config.cjs
Comment thread packages/sdk/svelte/package.json Outdated
@joker23 joker23 force-pushed the skz/sdk-2505/remove-unused-deps branch from a49004a to 58489a2 Compare June 24, 2026 13:55
@joker23 joker23 requested a review from kinyoklion June 24, 2026 13:56
@joker23 joker23 merged commit 008b1d6 into main Jun 24, 2026
55 checks passed
@joker23 joker23 deleted the skz/sdk-2505/remove-unused-deps branch June 24, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants