Skip to content

fix: Preserve fallthrough variation when cloning test data. #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 5, 2023
Merged

fix: Preserve fallthrough variation when cloning test data. #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34a0659
fix: Fix an issue where fallthrough variations were not preserved whe…
kinyoklion Jul 5, 2023
8457837
Use different id.
kinyoklion Jul 5, 2023
c1c6c40
Merge branch 'main' into rlamb/fix-testdata-fallthrough-clone
kinyoklion Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions packages/shared/sdk-server/__tests__/LDClient.evaluation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,33 @@ describe('given an LDClient with test data', () => {
client.close();
});

it('evaluates a flag which has a fallthrough and a rule', async () => {
Copy link
Member Author

@kinyoklion kinyoklion Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clone of the test case the user encountered.

const testId = 'abcd'.repeat(8);
const flagKey = 'testFlag';
await td.update(td.flag(flagKey).booleanFlag().variationForAll(true));
await td.update(td.flag(flagKey).ifMatch('user', 'testId', testId).thenReturn(false));

// Evaluate with no testId
const flagsState = await client.allFlagsState({
kind: 'user',
key: 'fake',
testId: undefined,
});

const features = flagsState.allValues();

expect(features[flagKey]).toBeTruthy();

const flagsStateWithTenant = await client.allFlagsState({
kind: 'user',
key: testId,
testId,
});

const featuresWithTenant = flagsStateWithTenant.allValues();
expect(featuresWithTenant[flagKey]).toBeFalsy();
});

it('evaluates an existing flag', async () => {
td.update(td.flag('flagkey').on(true).variations('a', 'b').fallthroughVariation(1));
expect(await client.variation('flagkey', defaultUser, 'c')).toBe('b');
Expand Down
12 changes: 11 additions & 1 deletion packages/shared/sdk-server/__tests__/integrations/test_data/TestData.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@ describe('given a TestData instance', () => {
it('can clone a complex flag configuration', () => {
const flag = td
.flag('test-flag')
.offVariation(true)
.variationForAll(false)
.variationForUser('billy', true)
.ifMatch('user', 'name', 'ben', 'christian')
.andNotMatch('user', 'country', 'fr')
.thenReturn(true);
Expand Down Expand Up @@ -199,7 +202,14 @@ describe('given a TestData instance', () => {
},
];

expect(flagCopy.build(1).rules).toEqual(flagRules);
const builtFlag = flagCopy.build(1);
expect(builtFlag.fallthrough).toEqual({ variation: 1 });
Copy link
Member Author

@kinyoklion kinyoklion Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test only verified rules before. Now it covers the basics as well.

expect(builtFlag.offVariation).toEqual(0);
expect(builtFlag.variations).toEqual([true, false]);
expect(builtFlag.contextTargets).toEqual([
{ contextKind: 'user', values: ['billy'], variation: 0 },
]);
expect(builtFlag.rules).toEqual(flagRules);
});

it('defaults a new flag to on', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/sdk-server/src/integrations/test_data/TestDataFlagBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default class TestDataFlagBuilder {
this.data.offVariation = data.offVariation;
}
if (data.fallthroughVariation !== undefined) {
this.data.offVariation = data.offVariation;
this.data.fallthroughVariation = data.fallthroughVariation;
Copy link
Member Author

@kinyoklion kinyoklion Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual copy/paste error.

}
if (data.targetsByVariation) {
this.data.targetsByVariation = JSON.parse(JSON.stringify(data.targetsByVariation));
Expand Down