Skip to content

chore: bump semver dep #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2023
Merged

chore: bump semver dep #205

merged 2 commits into from
Jul 19, 2023

Conversation

@yusinto
Copy link
Contributor

@yusinto yusinto commented Jul 17, 2023

Updating semver to latest. The reason it was pinned to 7.5.0 was because 7.5.0 introduced require('util') without the node: prefix. This has been fixed in 7.5.1 so we'll update to latest which is 7.5.4.

@shortcut-integration
Copy link

shortcut-integration bot commented Jul 17, 2023

This pull request has been linked to Shortcut Story #209876: chore: update semver dep.

@kinyoklion
Copy link
Member

kinyoklion commented Jul 17, 2023

What confidence level do we have that this will execute nicely in cloudflare, vercel, akamai? Are the current unit tests sufficiently representative of those environments?

@dariushar @ctawiah @monsagri

kinyoklion
kinyoklion requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@kinyoklion kinyoklion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes until my question is addressed.

@louis-launchdarkly louis-launchdarkly dismissed their stale review July 17, 2023 18:26

Ryan has an open question on this.

@yusinto yusinto requested review from dariushar and monsagri July 17, 2023 18:58
dariushar
dariushar approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@dariushar dariushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone else may be a little more confident than I am but I took a quick look at the Akamai and Vervel SDKs and I don't see any issues being caused by this

@ctawiah
Copy link
Contributor

ctawiah commented Jul 18, 2023

What confidence level do we have that this will execute nicely in cloudflare, vercel, akamai? Are the current unit tests sufficiently representative of those environments?

@dariushar @ctawiah @monsagri

LGTM

@monsagri
Copy link
Contributor

monsagri commented Jul 19, 2023

Looks good to me from what I can see!

@yusinto yusinto requested a review from kinyoklion July 19, 2023 18:12
@yusinto yusinto merged commit 8087dd9 into main Jul 19, 2023
@yusinto yusinto deleted the yus/sc-209876/chore-update-semver-dep branch July 19, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinyoklion kinyoklion kinyoklion approved these changes

@monsagri monsagri monsagri approved these changes

@ctawiah ctawiah ctawiah approved these changes

@dariushar dariushar dariushar approved these changes

+1 more reviewer

@louis-launchdarkly louis-launchdarkly louis-launchdarkly left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yusinto @kinyoklion @ctawiah @monsagri @louis-launchdarkly @dariushar