fix: broken local build due to sed -i warning #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #209890: Fix sed warning in because of replacing LD_VERSION. |
kinyoklion
reviewed
Jul 17, 2023
kinyoklion
approved these changes
Jul 17, 2023
yusinto
deleted the
yus/sc-209890/fix-sed-warning-in-becaues-of-replacing-ld
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround to replace sdk versions in replace-version.sh does not work locally on OS X because the sed command is not posix compliant. This breaks yarn build locally on os x.
On os x,
sed -iexpects the next argument to a backup file extension.On Linux/Unix, it does not.
This ticket implements a workaround for the workaround. As you can see, this is a rabbit hole which eventually is best solved by not using this script at all.