fix: Ensure that test data user targets are handled correctly. #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Aug 3, 2023
| variations: [...this.data.variations], | ||
| }; | ||
|
|
||
| if (this.data.targetsByVariation) { |
Member
Author
There was a problem hiding this comment.
The change in this file is the actual fix. Everything else is testing.
yusinto
approved these changes
Aug 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User targets require special logic to put the variation/values into
targetsinstead of just incontextTargets. This was not being done, so user specific targets were not evaluating correctly.Github issue: launchdarkly/node-server-sdk#283