Skip to content

feat: Optimize segment lookup for large segments. #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Aug 21, 2023
Merged

feat: Optimize segment lookup for large segments. #235

merged 38 commits into from
Aug 21, 2023

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Aug 11, 2023

No description provided.

@kinyoklion
feat: Do not use async for evaluation hotpath.
62f7b42
@kinyoklion
feat: Switch to es2017 target to ensure native async/await.
bdebdff
@kinyoklion
Remove pre-release versions.
fca0b27
@kinyoklion
Merge branch 'rlamb/switch-to-es2017' into rlamb/performance-experime…
d6686ba 
…ntation
@kinyoklion
Bug fixes.
83b7ede
@kinyoklion
Basic functionality working with eval callbacks.
4055933
@kinyoklion
Async data access.
96878e3
@kinyoklion
Conversion mostly complete.
33a982f
@kinyoklion
Debugging
c336712
@kinyoklion
Change recursion limit.
7d98812
@kinyoklion
Merge branch 'main' into rlamb/performance-experimentation
8b54759
@kinyoklion
Remove test from debugging.
33617dc
@kinyoklion
Cleanup.
26d0ede
@kinyoklion
Remove async from methods that return a promise directly.
17ff57a
@kinyoklion
feat: Optimize segment lookups for larger segments.
80e6516
@kinyoklion
Style changes.
19ad6b9
@kinyoklion
Merge branch 'rlamb/performance-experimentation' into rlamb/optimize-…
9f50e7d 
…large-segments
@kinyoklion
Fix callback name.
204de93
@kinyoklion
Add documentation about callbacks.
7a3ef53
@kinyoklion
Better iterator callback name.
31e4cda
@kinyoklion
Do not use a class for Match/MatchError
6908265
@kinyoklion
Merge branch 'rlamb/performance-experimentation' into rlamb/optimize-…
98c093b 
…large-segments
@kinyoklion
Evaluate all flags concurrently.
8a15e15
@kinyoklion
Merge branch 'main' into rlamb/performance-experimentation
3bca8a5
@kinyoklion
Merge branch 'main' into rlamb/performance-experimentation
9bba8dc
@kinyoklion
Merge branch 'rlamb/performance-experimentation' into rlamb/optimize-…
190b153 
…large-segments
@kinyoklion
Remove extra allFlags read.
79076df
@kinyoklion
Remove double allFlags
19c8a89
@kinyoklion
Merge branch 'rlamb/performance-experimentation' into rlamb/optimize-…
a9a881d 
…large-segments
@kinyoklion kinyoklion marked this pull request as ready for review August 18, 2023 22:22
@kinyoklion kinyoklion marked this pull request as draft August 18, 2023 22:23
@kinyoklion kinyoklion marked this pull request as ready for review August 18, 2023 22:25
yusinto
yusinto requested changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@yusinto yusinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we also able to add unit tests please?

Base automatically changed from rlamb/performance-experimentation to main August 21, 2023 19:57
@kinyoklion kinyoklion merged commit ac575d0 into main Aug 21, 2023
@kinyoklion kinyoklion deleted the rlamb/optimize-large-segments branch August 21, 2023 20:37
@github-actions github-actions bot mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yusinto yusinto yusinto approved these changes

@louis-launchdarkly louis-launchdarkly Awaiting requested review from louis-launchdarkly

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kinyoklion @yusinto