fix: Correct double callback in persistent store wrapper. #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
requested review from
louis-launchdarkly and
yusinto
as code owners
kinyoklion
commented
Aug 15, 2023
| const value = deserialize(persistKind, descriptor); | ||
| this.itemCache?.set(cacheKey(kind, key), value); | ||
| callback(itemIfNotDeleted(value)); | ||
| return; |
Member
Author
There was a problem hiding this comment.
In the case where there was item the callback was getting executed again. When using the async facade this worked fine, which is what the SDK has been doing. The callback based implementation does not use the facade, and was encountering this problem.
louis-launchdarkly
approved these changes
Aug 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.