chore: Implement maintenance release config. #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Feb 8, 2024
| yarn workspace $WORKSPACE npm publish || { echo "npm publish failed" >&2; exit 1; } | ||
| # Using a maintenance tag prevents this release from getting tagged with "latest". | ||
| echo "Publishing with maintenance tag." | ||
| yarn workspace $WORKSPACE npm publish --tag maintenance || { echo "npm publish failed" >&2; exit 1; } |
Member
Author
There was a problem hiding this comment.
If you do not include a tag, then it defaults to latest. This results in npm i @launcharkly/node-server-sdk installing the maintenance release. (This was a problem with releaser).
kinyoklion
requested review from
louis-launchdarkly and
yusinto
as code owners
yusinto
approved these changes
Feb 8, 2024
Contributor
yusinto
left a comment
yusinto
left a comment
There was a problem hiding this comment.
I'm approving, but a little disappointed RP does not support this in a more elegant fashion.
Member
Author
Well, it may, but it depends what is meant by elegant. This version is careful. I could just branch and change the branch name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for a maintenance branch for creating node-server-sdk releases.
It removes all builds related to other packages and can only build/release node-server-sdk.