chore: Update vercel examples to use workspace packages. #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #237150: Update vercel examples to use workspace deps.. |
yusinto
commented
Mar 19, 2024
| "private": true, | ||
| "scripts": { | ||
| "build": "next build", | ||
| "build-prod": "next build", |
Contributor
Author
There was a problem hiding this comment.
Exclude building these examples when we run yarn build at the repo root.
Alternatively, we can also modify the root build command to exclude all example*. I'm open to both ideas, but this is the easiest for now hence.
kinyoklion
approved these changes
Mar 19, 2024
yusinto
deleted the
yus/sc-237150/update-vercel-examples-to-use-workspace-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated @vercel/edge-config package to use the major version in this pr however I overlooked updating the corresponding example apps to use the workspace versions of our vercel sdk.