fix: Fix typings for big segment store factories. #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusinto
reviewed
Mar 29, 2024
|
|
||
| it('can construct options with a big segment store', () => { | ||
| // This is just a typescript test to ensure the typings match. | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
Contributor
There was a problem hiding this comment.
nit: We have the varsIgnorePattern eslint rule which we should correct to ignore unused vars:
'@typescript-eslint/no-unused-vars': [
'error',
{ ignoreRestSiblings: true, argsIgnorePattern: '^_', varsIgnorePattern: '^__' },
],Although vars with dangling underscores violate other eslint rules, which means we should use other patterns, like xx maybe.
yusinto
approved these changes
Mar 29, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Apr 1, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>node-server-sdk-dynamodb: 6.1.5</summary> ## [6.1.5](node-server-sdk-dynamodb-v6.1.4...node-server-sdk-dynamodb-v6.1.5) (2024-04-01) ### Bug Fixes * Fix typings for big segment store factories. ([#413](#413)) ([723804b](723804b)) </details> <details><summary>node-server-sdk-redis: 4.1.5</summary> ## [4.1.5](node-server-sdk-redis-v4.1.4...node-server-sdk-redis-v4.1.5) (2024-04-01) ### Bug Fixes * Fix typings for big segment store factories. ([#413](#413)) ([723804b](723804b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typings were incorrect for the factories. I am not making this a major version as internally the factories were being called with this type. Additionally the integrations don't use the logger which is what they access from these options.
The feature stores had the correct options.