Skip to content

fix: Include name and version in platform. #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2024
Merged

fix: Include name and version in platform. #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbc1345
fix: Include name and version in platform.
kinyoklion Apr 29, 2024
0145719
Use single quotes.
kinyoklion Apr 29, 2024
f3b9144
Add missing semicolon.
kinyoklion Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/sdk/cloudflare/src/createPlatformInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import type { Info, PlatformData, SdkData } from '@launchdarkly/js-server-sdk-common-edge';

// @ts-ignore
// eslint-disable-next-line prettier/prettier
import * as packageJson from '../package.json' assert { type: "json" }

const { name, version } = packageJson
const name = '@launchdarkly/cloudflare-server-sdk';
const version = '2.5.3'; // x-release-please-version

class CloudflarePlatformInfo implements Info {
platformData(): PlatformData {
Expand All @@ -22,6 +19,6 @@ class CloudflarePlatformInfo implements Info {
}
}

const createPlatformInfo = (): CloudflarePlatformInfo => new CloudflarePlatformInfo()
const createPlatformInfo = (): CloudflarePlatformInfo => new CloudflarePlatformInfo();

export default createPlatformInfo;
3 changes: 2 additions & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"type": "json",
"path": "jsr.json",
"jsonpath": "$.version"
}
},
"src/createPlatformInfo.ts"
]
},
"packages/sdk/react-native": {},
Expand Down