fix: Fix common package to work with node16 module resolution. #627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using typescript with moduleResolution set to "node16" types were not loading which are part of the common package.
This relates to changes to the default was in which file resolution occurs.
This PR will address this, but we will want a better long-term fix. In this PR we convince node that the
.d.tsfiles are the correct extension by making a smallpackage.jsonthat sets the module type.In the future we would want the
.d.tsfiles to instead be.d.cts.Potentially we can move to tsup: https://tsup.egoist.dev/
But the changes were too extensive for this fix.
Testing:
tsconfig.json
package.json
Code:
This uses a few types, such as the context, logger, and options to ensure they are resolving correctly.