fix: Fix race condition with client registration. #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
stasquatch
approved these changes
Jan 23, 2025
bwalker8038
approved these changes
Jan 23, 2025
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Jan 23, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>browser-telemetry: 0.1.1</summary> ## [0.1.1](browser-telemetry-v0.1.0...browser-telemetry-v0.1.1) (2025-01-23) ### Bug Fixes * Fix race condition with client registration. ([#750](#750)) ([d2ac2e2](d2ac2e2)) </details> <details><summary>server-sdk-ai: 0.8.0</summary> ## [0.8.0](server-sdk-ai-v0.7.1...server-sdk-ai-v0.8.0) (2025-01-23) ### Features * track timeToFirstToken in LDAIConfigTracker ([#749](#749)) ([c97674f](c97674f)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initialization the js-client-sdk does some context processing. This is an async operation which will add keys to anonymous contexts. Being as this doesn't happen synchronously within the initialization call there is a possibility that you register the telemetry SDK before that initialization is complete.
This PR updates the registration to attempt to wait for initialization. This is a larger window than we need to wait, but ensures that process will be complete.