Skip to content

fix: Fix issue where flush callback could be called twice. #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: Fix issue where flush callback could be called twice. #779

merged 1 commit into from
Feb 18, 2025

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Feb 14, 2025 •
edited
Loading

Relates to #777

kinyoklion
kinyoklion commented Feb 14, 2025
View reviewed changes
packages/shared/sdk-server/src/LDClientImpl.ts
Copy link
Member Author

@kinyoklion kinyoklion Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our interface documentation there is another issue with this implementation. We say the function rejects, but it doesn't actually. I am more concerned about changing that as it is likely to introduce problems. We may instead consider changing the API documentation and suggesting using the callback if the error is required.

Additionally you cannot retry if it fails, at least not the same payload, as those events will have been discarded by that time.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 19014 bytes
Size limit: 21000

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15371 bytes
Size limit: 20000

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 19871 bytes
Size limit: 21000

@kinyoklion kinyoklion marked this pull request as ready for review February 14, 2025 23:38
@kinyoklion kinyoklion requested a review from a team as a code owner February 14, 2025 23:38
@kinyoklion kinyoklion merged commit c377e89 into main Feb 18, 2025
23 checks passed
@kinyoklion kinyoklion deleted the rlamb/sdk-1070/fix-duplicate-flush-callback branch February 18, 2025 16:24
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Merged
kinyoklion pushed a commit that referenced this pull request Feb 18, 2025
@github-actions
chore: release main (#780)
1b7351e 
🤖 I have created a release *beep* *boop*
---


<details><summary>akamai-edgeworker-sdk-common: 1.4.1</summary>

##
[1.4.1](akamai-edgeworker-sdk-common-v1.4.0...akamai-edgeworker-sdk-common-v1.4.1)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from ^2.11.0 to ^2.11.1
</details>

<details><summary>akamai-server-base-sdk: 2.1.23</summary>

##
[2.1.23](akamai-server-base-sdk-v2.1.22...akamai-server-base-sdk-v2.1.23)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.4.0 to
^1.4.1
    * @launchdarkly/js-server-sdk-common bumped from ^2.11.0 to ^2.11.1
</details>

<details><summary>akamai-server-edgekv-sdk: 1.4.1</summary>

##
[1.4.1](akamai-server-edgekv-sdk-v1.4.0...akamai-server-edgekv-sdk-v1.4.1)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.4.0 to
^1.4.1
    * @launchdarkly/js-server-sdk-common bumped from ^2.11.0 to ^2.11.1
</details>

<details><summary>cloudflare-server-sdk: 2.6.5</summary>

##
[2.6.5](cloudflare-server-sdk-v2.6.4...cloudflare-server-sdk-v2.6.5)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common-edge bumped from 2.5.3 to 2.5.4
</details>

<details><summary>js-server-sdk-common: 2.11.1</summary>

##
[2.11.1](js-server-sdk-common-v2.11.0...js-server-sdk-common-v2.11.1)
(2025-02-18)


### Bug Fixes

* Fix issue where flush callback could be called twice.
([#779](#779))
([c377e89](c377e89))
</details>

<details><summary>js-server-sdk-common-edge: 2.5.4</summary>

##
[2.5.4](js-server-sdk-common-edge-v2.5.3...js-server-sdk-common-edge-v2.5.4)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.11.0 to 2.11.1
</details>

<details><summary>node-server-sdk: 9.7.4</summary>

##
[9.7.4](node-server-sdk-v9.7.3...node-server-sdk-v9.7.4)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.11.0 to 2.11.1
</details>

<details><summary>node-server-sdk-dynamodb: 6.2.4</summary>

##
[6.2.4](node-server-sdk-dynamodb-v6.2.3...node-server-sdk-dynamodb-v6.2.4)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.7.3 to 9.7.4
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.4
</details>

<details><summary>node-server-sdk-otel: 1.1.4</summary>

##
[1.1.4](node-server-sdk-otel-v1.1.3...node-server-sdk-otel-v1.1.4)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.7.3 to 9.7.4
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.4
</details>

<details><summary>node-server-sdk-redis: 4.2.4</summary>

##
[4.2.4](node-server-sdk-redis-v4.2.3...node-server-sdk-redis-v4.2.4)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.7.3 to 9.7.4
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.4
</details>

<details><summary>server-sdk-ai: 0.9.1</summary>

##
[0.9.1](server-sdk-ai-v0.9.0...server-sdk-ai-v0.9.1)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.11.0 to 2.11.1
  * peerDependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.x to 2.11.1
</details>

<details><summary>vercel-server-sdk: 1.3.23</summary>

##
[1.3.23](vercel-server-sdk-v1.3.22...vercel-server-sdk-v1.3.23)
(2025-02-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common-edge bumped from 2.5.3 to 2.5.4
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanderson-ld tanderson-ld tanderson-ld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kinyoklion @tanderson-ld