fix: Fix cancelling timeout when waitForInitialization throws an exception #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
tanderson-ld
approved these changes
Mar 21, 2025
abarker-launchdarkly
deleted the
abarker/sdk-1132/fix-wait-for-initialization-timeout-cancel
branch
Merged
abarker-launchdarkly
pushed a commit
that referenced
this pull request
Mar 21, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>akamai-edgeworker-sdk-common: 2.0.2</summary> ## [2.0.2](akamai-edgeworker-sdk-common-v2.0.1...akamai-edgeworker-sdk-common-v2.0.2) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from ^2.12.0 to ^2.12.1 </details> <details><summary>akamai-server-base-sdk: 3.0.2</summary> ## [3.0.2](akamai-server-base-sdk-v3.0.1...akamai-server-base-sdk-v3.0.2) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^2.0.1 to ^2.0.2 * @launchdarkly/js-server-sdk-common bumped from ^2.12.0 to ^2.12.1 </details> <details><summary>akamai-server-edgekv-sdk: 1.4.4</summary> ## [1.4.4](akamai-server-edgekv-sdk-v1.4.3...akamai-server-edgekv-sdk-v1.4.4) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^2.0.1 to ^2.0.2 * @launchdarkly/js-server-sdk-common bumped from ^2.12.0 to ^2.12.1 </details> <details><summary>cloudflare-server-sdk: 2.7.1</summary> ## [2.7.1](cloudflare-server-sdk-v2.7.0...cloudflare-server-sdk-v2.7.1) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.6.0 to 2.6.1 </details> <details><summary>fastly-server-sdk: 0.1.2</summary> ## [0.1.2](fastly-server-sdk-v0.1.1...fastly-server-sdk-v0.1.2) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.12.0 to 2.12.1 </details> <details><summary>js-server-sdk-common: 2.12.1</summary> ## [2.12.1](js-server-sdk-common-v2.12.0...js-server-sdk-common-v2.12.1) (2025-03-21) ### Bug Fixes * Fix cancelling timeout when waitForInitialization throws an exception ([#808](#808)) ([bb3c950](bb3c950)) </details> <details><summary>js-server-sdk-common-edge: 2.6.1</summary> ## [2.6.1](js-server-sdk-common-edge-v2.6.0...js-server-sdk-common-edge-v2.6.1) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.12.0 to 2.12.1 </details> <details><summary>node-server-sdk: 9.7.6</summary> ## [9.7.6](node-server-sdk-v9.7.5...node-server-sdk-v9.7.6) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.12.0 to 2.12.1 </details> <details><summary>node-server-sdk-dynamodb: 6.2.6</summary> ## [6.2.6](node-server-sdk-dynamodb-v6.2.5...node-server-sdk-dynamodb-v6.2.6) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.7.5 to 9.7.6 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.6 </details> <details><summary>node-server-sdk-otel: 1.1.6</summary> ## [1.1.6](node-server-sdk-otel-v1.1.5...node-server-sdk-otel-v1.1.6) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.7.5 to 9.7.6 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.6 </details> <details><summary>node-server-sdk-redis: 4.2.6</summary> ## [4.2.6](node-server-sdk-redis-v4.2.5...node-server-sdk-redis-v4.2.6) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.7.5 to 9.7.6 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.6 </details> <details><summary>server-sdk-ai: 0.9.3</summary> ## [0.9.3](server-sdk-ai-v0.9.2...server-sdk-ai-v0.9.3) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common bumped from 2.12.0 to 2.12.1 * peerDependencies * @launchdarkly/js-server-sdk-common bumped from 2.x to 2.12.1 </details> <details><summary>vercel-server-sdk: 1.3.25</summary> ## [1.3.25](vercel-server-sdk-v1.3.24...vercel-server-sdk-v1.3.25) (2025-03-21) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.6.0 to 2.6.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
https://launchdarkly.atlassian.net/browse/SDK-1132
Describe the solution you've provided
Previously the timeout was cancelled in a
then()and would be skipped if the base promise threw an exception. The cancelation was moved tofinally()where it will always be called regardless of an exception.Describe alternatives you've considered
N/A
Additional context
N/A