Skip to content

Conversation

@abarker-launchdarkly
Copy link
Contributor

The contributed work was already reviewed in the original PR (#722) which was merged into this temporary holding branch to:

  • Standardize the README files to be consistent with our other documentation
  • Add the build/test github action workflow for the Svelte SDK

Only the changes made in commit 79b42ae need to be reviewed.

nosnibor89 and others added 2 commits May 14, 2025 09:33
**Requirements**

- [x] I have added test coverage for new or changed functionality (no
behavior change is mostly example project and docs)
- [x] I have followed the repository's [pull request submission
guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
- [x] I have validated my changes against all supported platform
versions

**Related issues**

No issue.

**Describe the solution you've provided**

This pull request introduces a new Svelte example project to demonstrate
the usage of `@launchdarkly/svelte-client-sdk`. The README of the
example project includes steps to run such application that internally
uses the SDK to interact with a boolean flag.

Also, this PR adds documentation for `@launchdarkly/svelte-client-sdk`
itself with a "Getting Started" session along with more advanced use of
the SDK's api.

**Describe alternatives you've considered**

I don't know what to write here.

**Additional context**

This is a follow up PR for
#632. Where Svelte SDK was
introduced.

After this, follow up PR for technical debt(upgrade Svelte 5 and
improving test coverage ) should be expected

---------

Co-authored-by: Robinson Marquez <nosnibor1989@gmail.com>
Co-authored-by: Robinson Marquez <robinsonmarquez@robinsonmarquezm4.local>
@abarker-launchdarkly abarker-launchdarkly requested a review from a team as a code owner May 14, 2025 14:21
@github-actions
Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 23840 bytes
Size limit: 25000

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 20702 bytes
Size limit: 21000

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15786 bytes
Size limit: 20000

@abarker-launchdarkly abarker-launchdarkly merged commit de13740 into main May 15, 2025
25 checks passed
@abarker-launchdarkly abarker-launchdarkly deleted the feat/svelte-sdk-example branch May 15, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants