feat(icons): add new probability density chart icon#1600
Closed
Conversation
🦋 Changeset detectedLatest commit: 2cd3772 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
|
Size Change: 0 B Total Size: 526 kB ℹ️ View Unchanged
|
awinders-launchdarkly
approved these changes
Mar 31, 2025
Contributor
awinders-launchdarkly
left a comment
awinders-launchdarkly
left a comment
There was a problem hiding this comment.
That's a real beaut Claire
matthewferry
suggested changes
Mar 31, 2025
Contributor
matthewferry
left a comment
matthewferry
left a comment
There was a problem hiding this comment.
Do you have a link to the Figma designs? This icon doesn't quite follow the guidelines:
- is a fill instead of outline
- isn't centered and sized to the 20x20 grid
- uses hard edges instead of soft edges
Contributor
Author
|
@matthewferry yep for sure - here's the link to the figma https://www.figma.com/design/U87UUxXqNpronIMBalm6HS/Experimentation-Refresh---Results-2?node-id=742-471430&m=dev |
Contributor
Author
|
@OneHunnid could you please give this a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds new probability density chart icon to support experiment results page changes
Screenshots (if appropriate):
Testing approaches