feat: allow nil to be passed for clientInit config #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #234812: Allow passing nil for default config in Lua. |
kinyoklion
approved these changes
Mar 11, 2024
Member
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
This doesn't feel more idiomatic to me, but it also doesn't feel harmful.
This was referenced Mar 11, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Mar 11, 2024
🤖 I have created a release *beep* *boop* --- ## [2.1.0](v2.0.6...v2.1.0) (2024-03-11) ### Features * allow nil to be passed for clientInit config ([#94](#94)) ([e7c0dfe](e7c0dfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny feature allows users to pass
nilas the third argument toclientInitto request default configuration:Before, you had to explicitly pass an empty
{}table. I think this is more idiomatic/intuitive. I could be wrong.