fix(observability-node): move @graphql-codegen/cli to devDependencies#480
Closed
fix(observability-node): move @graphql-codegen/cli to devDependencies#480
Conversation
@graphql-codegen/cli is only used by the codegen script (build-time type generation from the GraphQL schema). Keeping it under dependencies pulled lodash@4.17.x into consumers' runtime dependency trees via @graphql-codegen/plugin-helpers, triggering 13 high-severity npm audit findings (GHSA-r5fr-rjxr-66jc, GHSA-f23m-r3pf-42rh, GHSA-xxjr-mmjv-4gpg). Every other package in the monorepo already places this under devDependencies; this aligns observability-node with that pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
superceded by #479 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@launchdarkly/observability-node@1.1.0that traced back tolodashvia@graphql-codegen/cli → @graphql-codegen/plugin-helpers.@graphql-codegen/cliis only used by thecodegenscript (codegen.ts) for build-time GraphQL type generation; runtime imports come from@graphql-typed-document-node/core. Every other package in this monorepo already places it underdevDependencies.Test plan
yarn turbo run build --filter @launchdarkly/observability-nodeyarn turbo run test --filter @launchdarkly/observability-node(63 tests pass)🤖 Generated with Claude Code
Note
Low Risk
Low risk dependency metadata change; the main impact is on build tooling availability rather than runtime behavior.
Overview
Moves
@graphql-codegen/clifromdependenciestodevDependenciesin@launchdarkly/observability-node, so the GraphQL codegen tool is no longer installed for downstream consumers and only used during development/build.Reviewed by Cursor Bugbot for commit 73968c0. Bugbot is set up for automated code reviews on this repo. Configure here.