feat!: Upgrade to LaunchDarkly.ServerSdk 7.0.0+ and implement support for building contexts. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Feb 13, 2023
README.md
Outdated
| ## OpenFeature Specific Considerations | ||
|
|
||
| When evaluating a `User` with the LaunchDarkly Server-Side SDK for .NET a string `key` attribute would normally be required. When using OpenFeature the `targetingKey` attribute should be used instead of `key`. If a `key` attribute is provided in the `EvaluationContext`, then it will be discarded in favor of `targetingKey`. If a `targetingKey` is not provided, or if the `EvaluationContext` is omitted entirely, then the `defaultValue` will be returned from OpenFeature evaluation methods. | ||
| LaunchDarkly evaluates contexts, and it can either evaluate a single-context, or a multi-context. When using OpenFeature both single and multi-contexts must be encoded into a single `EvaluationContext`. This is accomplished by looking an attribute named `kind` in the `EvaluationContext`. |
Member
Author
There was a problem hiding this comment.
We do not have docs on the docs site yet for OpenFeature providers, so the README needs to be more elaborate to explain contexts and how you make them.
kinyoklion
commented
Feb 13, 2023
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="LaunchDarkly.ServerSdk" Version="[6.3.2,7.0)" /> | ||
| <PackageReference Include="LaunchDarkly.ServerSdk" Version="[7.0,8.0)" /> |
Member
Author
There was a problem hiding this comment.
Should work with major versions until 8, which it should not work with.
kinyoklion
commented
Feb 13, 2023
| _client = client; | ||
| var logConfig = (config?.LoggingConfigurationFactory ?? Components.Logging()) | ||
| .CreateLoggingConfiguration(); | ||
| .Build(null); |
Member
Author
There was a problem hiding this comment.
This is extremely questionable. I've not determined if there is anything else I can really do about it.
kinyoklion
commented
Feb 13, 2023
| .Set("anonymous", true).Build(); | ||
|
|
||
| var convertedUser = _converter.ToLdUser(evaluationContext); | ||
| var convertedUser = _converter.ToLdContext(evaluationContext); |
Member
Author
There was a problem hiding this comment.
I left these tests mostly intact using User, and then added new a couple new tests.
keelerm84
approved these changes
Feb 14, 2023
Co-authored-by: Matthew M. Keeler <keelerm84@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.