feat!: Update dependencies and encapsulate client construction. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
force-pushed
the
rlamb/change-construction-method
branch
5 times, most recently
from
472194a to
6761fed
Compare
kinyoklion
commented
Oct 30, 2023
| variations: [ | ||
| {os: ubuntu-latest, node: latest}, | ||
| {os: ubuntu-latest, node: 14}, | ||
| {os: ubuntu-latest, node: 16}, |
Member
Author
There was a problem hiding this comment.
OpenFeature SDK requires node 16.
kinyoklion
force-pushed
the
rlamb/change-construction-method
branch
from
6761fed to
5e8d180
Compare
kinyoklion
commented
Oct 30, 2023
| ], | ||
| "license": "Apache-2.0", | ||
| "peerDependencies": { | ||
| "@openfeature/js-sdk": "^1.0.0", |
Member
Author
There was a problem hiding this comment.
The OpenFeature SDK was renamed to make it clear that their is a client and server version.
kinyoklion
commented
Oct 30, 2023
| constructor(sdkKey: string, options: LDOptions = {}) { | ||
| if (options.logger) { | ||
| this.logger = options.logger; | ||
| this.logger = new SafeLogger(options.logger, basicLogger({ level: 'info' })); |
Member
Author
There was a problem hiding this comment.
This is just a fix, it should have had this already.
kinyoklion
commented
Oct 30, 2023
| this.logger = basicLogger({ level: 'info' }); | ||
| } | ||
| try { | ||
| this.client = init(sdkKey, { |
Member
Author
There was a problem hiding this comment.
There are a few cases where the constructor fails. I am capturing it and letting the OF SDK handle it. That seems most in the spirit of the functionality. Maybe a little less convenient though.
keelerm84
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to latest OpenFeature SDK.
Updates to latest LD SDK. Addresses #34
Adds support for OpenFeature events.
Adds support for provider shutdown. Addresses #15.